Fix the creation of tags with types in StandardTagFactory
#438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jan 20, 2026
mspirkov
commented
Jan 20, 2026
Member
|
Thanks to you both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jaapio It seems to me that you forgot to do something here: https://github.com/phpDocumentor/ReflectionDocBlock/pull/429/changes#diff-0a54b372c4e4b90d958830938d282b2fe77063cbf4a3f259b2ecf19b14f862f5L104
Together with @stof, we found this issue here: https://github.com/phpspec/prophecy/pull/660/files/c8163365fe794c184f8939fdb4b3f4c4df257270#diff-182b6b3361b404112a4866aacc525865fcf2b17c9cdcfc78d8aa7a6f75102bec
At first, I thought it was a misuse issue, but now I realize it's a problem with ReflectionDocBlock.