Fixed and simplified array_replace description

[cartok]

Relates to: php/doc-de#76

[cmb69]

Wouldn't that be the description of array_merge()? It is certainly not what array_replace() is doing; see e.g. https://3v4l.org/XfXpa.

It seems to me that the current description is a bit verbose, but basically correct; it is only misleading, that the description suggests that the first array would be mutated. Maybe similar wording as for str_replace() might be used.

[cartok]

Yea ok, "joining" is propably not the best fitting word here.

What about this?

creates a new array by joining all given arrays in given order, replacing values of already existing keys.

In the end the arrays are joined but it goes by keys, not indices. They not are just concatenated like in array_merge

[Crell]

Suggested change

	<function>array_replace</function> creates a new array by joining all given arrays in given order, replacing values of already existing keys.
	<function>array_replace</function> creates a new array and assigns an item into it for each key in each of the provided arrays. If a key appears in multiple input arrays, the latter array's value is used.

How about this?

[cartok]

For me its implicit that the latter arrays value is used from the former short description. Another thing is that it does not only assigns keys to the new array

[Crell]

A little redundancy here is fine, especially as it's in a different section. Good point on the key/value question. I've updated the suggestion comment above.

[cmb69]

This would be rendered as:

This doesn't look like any improvement to me.

[cartok]

This would be rendered as:

This doesn't look like any improvement to me.

Why not, formatting / display or content?

[cmb69]

Why not, formatting / display or content?

Almost everything. If you describe something, it doesn't make much sense to start telling what it is not (let alone that a sentence should end with a period, and there rarely is the need to have single sentence paragraphs). Furthermore, "joining" might easily mislead readers to associate that with https://www.php.net/join (yeah, that function is still a thing).
In my opinon, @Crell's suggestion as well as my suggestion are better than what we have here.

[cartok]

Why not, formatting / display or content?

Almost everything. If you describe something, it doesn't make much sense to start telling what it is not (let alone that a sentence should end with a period, and there rarely is the need to have single sentence paragraphs). Furthermore, "joining" might easily mislead readers to associate that with https://www.php.net/join (yeah, that function is still a thing). In my opinon, @Crell's suggestion as well as my suggestion are better than what we have here.

If you think so. I rather want to read short facts and not complicated stories on such a simple thing. Feel free to close it.