Fix Dom\Element nodeValue in AbstractEncoderTest#18
Merged
Conversation
Replace nodeValue with textContent on Dom\Element nodes. With veewee/xml 4.x using PHP 8.4's new Dom\ classes, nodeValue returns null for element nodes per the DOM spec. textContent is the correct property for reading the text content of an element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$result->nodeValuewith$result->textContentinAbstractEncoderTest(76 occurrences)Why
With veewee/xml 4.x using PHP 8.4's new
Dom\classes,Dom\Element::nodeValuereturnsnullfor element nodes per the DOM spec. The correct property for reading text content of an element istextContent.This caused 70 test failures in downstream packages (e.g.
ext-soap-engine) after upgrading to engine-integration-tests 1.11.0 with veewee/xml 4.x.Test plan
ext-soap-enginewith this fix applied (both local PHP 8.4.13 and Docker PHP 8.4.19 with libxml 2.9.14)