feat(site): update doc-core to 1.20.0#4946
Open
wise-king-sullyman wants to merge 7 commits intomainfrom
Open
Conversation
Deploying patternfly-org with
|
| Latest commit: |
ab7e423
|
| Status: | 🚫 Build failed. |
nicolethoen
reviewed
Mar 3, 2026
Collaborator
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
does this change mean that composing pages with embedded react components should be constructed or located differently than before? that'll be important to communicate to Erin.
| import React from 'react'; | ||
| import { Link as ReachLink, navigate } from '@reach/router'; | ||
| import { getAsyncComponent } from '../../routes'; | ||
| const { getAsyncComponent } = require('../../routes'); |
Collaborator
There was a problem hiding this comment.
I don't understand why you'd be mixing import and require() in the same file
| "ci:build": "yarn generate:content && yarn build", | ||
| "clean": "rm -rf src/generated", | ||
| "generate:content": "patternfly-doc-core convert-to-mdx ../documentation-site/patternfly-docs/content/", | ||
| "generate:content": "rm -rf src/content && cp -r ../documentation-site/patternfly-docs/content src/content", |
Collaborator
There was a problem hiding this comment.
does doc-core 1.20.0 handle .md files natively now without needing to convert to mdx?
| "astro": "^5.16.10" | ||
| "@patternfly/patternfly-doc-core": "^1.20.0", | ||
| "@patternfly/react-icons": "^6.5.0-prerelease.14", | ||
| "astro": "^5.15.9" |
Collaborator
There was a problem hiding this comment.
Is this an intentional bump down for the astro version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4930