fix(pfFilter): fix plugin filters do not work if tables are set up serverSide#1095
fix(pfFilter): fix plugin filters do not work if tables are set up serverSide#1095pebri86 wants to merge 6 commits intopatternfly:masterfrom
Conversation
package.json
Outdated
| "license": "Apache-2.0", | ||
| "dependencies": { | ||
| "bootstrap": "~3.3.7", | ||
| "datatables": "^1.10.18", |
There was a problem hiding this comment.
adding datatables as a required dependency is probably going to be a challenge for users, these should be absolute must-haves for users of PatternFly - can this be added as an optional dependency instead?
There was a problem hiding this comment.
Ah thanks for your response, sure i'll move it to optional dependency
Move datatables as optional dependencies
pebri86
left a comment
pebri86
left a comment
There was a problem hiding this comment.
I have moved datatables as optional dependency. thank you
|
The JS looks good - added @michael-coker to take a glance at the css if possible. |
|
I can't find the elements that the CSS modifications apply to in any of the table view test pages. What do I need to do to see the changes in |
4 participants
fix(pfFilter): fix plugin filters do not work if tables are set up serverSide
fix #1092
Description
fix pfFilter to use filtering on server side when datatable are set up using serverSide options.
Changes
Write a list of changes the PR introduces