Feat: Proxy aware chain extensions#2383
Open
LandynDev wants to merge 4 commits intoopentensor:devnet-readyfrom
Open
Feat: Proxy aware chain extensions#2383LandynDev wants to merge 4 commits intoopentensor:devnet-readyfrom
LandynDev wants to merge 4 commits intoopentensor:devnet-readyfrom
Conversation
open-junius
reviewed
Jan 30, 2026
| pallet_proxy::Pallet::<T>::find_proxy( | ||
| &real_coldkey, | ||
| &caller, | ||
| Some(ProxyType::Staking), |
Contributor
There was a problem hiding this comment.
Should we check other ProxyType like Any also enable the add_stake call.
Contributor
|
All V2 extensions are not the upgrade or replace of V1. Could use the name like proxy_xxx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed the chain extensions aren't proxy aware
Functions like
TransferStakeV1useenv.caller()directly as the origin - https://github.com/opentensor/subtensor/blob/main/chain-extensions/src/lib.rs#L245If I'm understanding this right, it means the contract must be the coldkey that owns the stake and proxy relationships aren't checked. Even if a contract has valid proxy permissions, it is forced to use call_runtime with
Proxy::proxywrapping instead of chain extensions b/c of this.Type of Change
Breaking Change
This PR does not create a breaking change.
These extensions are primarily copies of the v1 versions, just each with:
real_coldkeyinput parameter introducedreal_coldkey!=env.caller()Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctlyScreenshots
Additional Notes
real_coldkeybe passed to the extension. However, this is a little counter intuitive for future contracts that aren't acting on behalf of proxy delegations as they may think "Why do I need to pass who I am (real coldkey)?"