fix: remove unused --hotkey option and split inspect into two tables#841
Open
Nicknamess96 wants to merge 1 commit intoopentensor:stagingfrom
Open
fix: remove unused --hotkey option and split inspect into two tables#841Nicknamess96 wants to merge 1 commit intoopentensor:stagingfrom
Nicknamess96 wants to merge 1 commit intoopentensor:stagingfrom
Conversation
Remove the regressed --hotkey parameter from wallet inspect command and split the single 9-column table into two focused tables: a Coldkey Overview table and a Hotkey Details table. - Remove wallet_hotkey parameter from wallet_inspect signature - Update help text to reflect coldkey-only wallet display - Refactor inspect output into separate coldkey and hotkey tables - Extract helper functions for delegate/neuron row generation - Add unit tests for all new helper functions - Remove unused itertools import Fixes opentensor#233
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Address the remaining work from #233 by removing the regressed
--hotkeyparameter from the wallet inspect command and splitting the single combined table into two separate, focused tables as suggested by @thewhaleking.PR #770 previously removed the
--hotkeyoption, but subsequent merges re-introduced the parameter and reverted the help text. This PR re-applies those fixes and additionally splits the inspect output into:Changes
wallet_hotkeyparameter fromwallet_inspectCLI handlerNonefor hotkey inwallet_askcall (hotkey is not used by inspect)_build_coldkey_table,_build_hotkey_table,_make_delegate_rows,_make_neuron_rows,_resolve_delegate_name,_calculate_daily_return,_format_hotkey_label,_populate_coldkey_table,_populate_hotkey_tableitertoolsimportFixes #233
Testing
pytest tests/unit_tests/-- 81 passed)ruff format .(v0.11.5)ruff check .on changed files