Skip to content

Conversation

@kuiwang02
Copy link
Contributor

@kuiwang02 kuiwang02 commented Dec 31, 2025

/cc @Xia-Zhao-rh

Summary

Add new step registry component openshift-extended-olm-test-hcp for running OLM tests on HCP (Hosted Control Plane) clusters like ROSA HCP.

Motivation

HCP clusters (ROSA HCP, HyperShift) do not have Machine CRDs since the control plane is managed externally. The existing openshift-e2e-test step includes machine/node count validation that fails on HCP clusters with:

error: the server doesn't have a resource type "machines"

This new step removes the Machine API dependency checks while preserving all other test functionality.

Changes

Created new step: ci-operator/step-registry/openshift-extended/olm-test/hcp/

Key differences from standard openshift-e2e-test step:

  • ✅ Skips machine/node count matching validation (lines 148-150)
  • ✅ Directly validates node readiness without checking Machine CRDs
  • ✅ AWS-only support (designed for ROSA HCP clusters)
  • ✅ Maintains all other functionality: cluster stability checks, test execution, sippy integration

What's removed:

  • Machine API resource checks (kubectl get machines)
  • GCP-specific configurations (not applicable to ROSA HCP)

@openshift-ci openshift-ci bot requested a review from Xia-Zhao-rh December 31, 2025 01:28
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 31, 2025
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 31, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@kuiwang02: no rehearsable tests are affected by this change

@kuiwang02
Copy link
Contributor Author

/verified by @kuiwang02

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 31, 2025
@openshift-ci-robot
Copy link
Contributor

@kuiwang02: This PR has been marked as verified by @kuiwang02.

Details

In response to this:

/verified by @kuiwang02

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kuiwang02 kuiwang02 changed the title add hcp step based on openshift-test OCPQE-31377: add hcp step based on openshift-test Dec 31, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 31, 2025

@kuiwang02: This pull request references OCPQE-31377 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

/cc @Xia-Zhao-rh

Summary

Add new step registry component openshift-extended-olm-test-hcp for running OLM tests on HCP (Hosted Control Plane) clusters like ROSA HCP.

Motivation

HCP clusters (ROSA HCP, HyperShift) do not have Machine CRDs since the control plane is managed externally. The existing openshift-e2e-test step includes machine/node count validation that fails on HCP clusters with:

error: the server doesn't have a resource type "machines"

This new step removes the Machine API dependency checks while preserving all other test functionality.

Changes

Created new step: ci-operator/step-registry/openshift-extended/olm-test/hcp/

Key differences from standard openshift-e2e-test step:

  • ✅ Skips machine/node count matching validation (lines 148-150)
  • ✅ Directly validates node readiness without checking Machine CRDs
  • ✅ AWS-only support (designed for ROSA HCP clusters)
  • ✅ Maintains all other functionality: cluster stability checks, test execution, sippy integration

What's removed:

  • Machine API resource checks (kubectl get machines)
  • GCP-specific configurations (not applicable to ROSA HCP)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 31, 2025
@Xia-Zhao-rh
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 31, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kuiwang02, Xia-Zhao-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 31, 2025

@kuiwang02: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0059c9e into openshift:master Dec 31, 2025
10 checks passed
@kuiwang02 kuiwang02 deleted the addolmstep branch December 31, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants