[WIP] CONSOLE-5068: Remove createModalLauncher from modal factory

[sg00dwin]

This PR must wait to merge after all dependency modal migration PRs have merged.

Summary

Removes the deprecated createModalLauncher function and all associated types from public/components/factory/modal.tsx. This is the final cleanup step in the CONSOLE-5012 modal migration effort.

Currently, createModalLauncher is replaced with a deprecated no-op stub so the build passes while consumer migration PRs are in flight. Once all dependency PRs merge and remove their usage, a follow-up commit will delete the stub entirely.

Changes

Removed from modal.tsx:

• createModal function
• createModalLauncher implementation (replaced with no-op stub)
• GetModalContainer type
• CreateModal type
• Unused imports: ReactDOM, Provider, Router, CompatRouter, store, history, PluginStoreProvider, pluginStore

Retained (still in use by migrated modals):

• ModalWrapper, ModalTitle, ModalBody, ModalFooter, ModalSubmitFooter
• ModalComponentProps

Temporarily retained as deprecated stubs (to be removed once all consumers are migrated):

• createModalLauncher (no-op)
• CreateModalLauncher type
• CreateModalLauncherProps type

Dependencies

PR	Status	Modals
#15932	Merged	delete-modal, delete-pvc, expand-pvc, clone-pvc, restore-pvc
#15939	Merged	configure-update-strategy, configure-ns-pull-secret, configure-cluster-upstream, managed-resource-save, remove-user
#15940	Merged	ResourceLimitsModal, ConfigureUnschedulableModal, DeletePDBModal
#15946	Merged	error-modal
#15990	Merged	PubSubModal, alert-routing, column-management, labels-modal, tags/annotations
#15997	Open	add-users, cluster-channel, cluster-more-updates, cluster-update, tolerations
#15968	Open	taints-modal + 9 OLM modals
#15935	Open	DeleteHPAModal, ConsolePluginModal
#15948	Open	confirm-modal
#16022	Open	DeleteResourceModal
#16063	Open	ExportApplicationModal, rollback-modal

Test plan

• All migration PRs merged first
• yarn build compiles without errors
• yarn lint passes
• yarn test passes
• No runtime errors when opening any modal in the console

Assisted by Claude Code

[openshift-ci-robot]

@sg00dwin: This pull request references CONSOLE-5068 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR must wait to merge after all dependency modal migration PRs have merged.

Summary

Removes the deprecated createModalLauncher function and all associated types from public/components/factory/modal.tsx. This is the final cleanup step in the CONSOLE-5012 modal migration effort.

Changes

Removed from modal.tsx:

• createModal function
• createModalLauncher function
• CreateModalLauncher type
• CreateModalLauncherProps type
• CreateModal type
• GetModalContainer type
• Unused imports: ReactDOM, Provider, Router, CompatRouter, store, history, PluginStoreProvider, pluginStore

Retained (still in use by migrated modals):

• ModalWrapper, ModalTitle, ModalBody, ModalFooter, ModalSubmitFooter
• ModalComponentProps

Dependencies

PR	Status	Modals
#15932	Merged	delete-modal, delete-pvc, expand-pvc, clone-pvc, restore-pvc
#15939	Merged	configure-update-strategy, configure-ns-pull-secret, configure-cluster-upstream, managed-resource-save, remove-user
#15940	Merged	ResourceLimitsModal, ConfigureUnschedulableModal, DeletePDBModal
#15946	Merged	error-modal
#15990	Merged	PubSubModal, alert-routing, column-management, labels-modal, tags/annotations
#15997	Open	add-users, cluster-channel, cluster-more-updates, cluster-update, tolerations
#15968	Open	taints-modal + 9 OLM modals
#15935	Open	DeleteHPAModal, ConsolePluginModal
#15948	Open	confirm-modal
#16022	Open	DeleteResourceModal
#16063	Open	ExportApplicationModal, rollback-modal

Test plan

• All migration PRs merged first
• yarn build compiles without errors
• yarn lint passes
• yarn test passes
• No runtime errors when opening any modal in the console

Assisted by Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sg00dwin
Once this PR has been reviewed and has the lgtm label, please assign jhadvig for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@sg00dwin: This pull request references CONSOLE-5068 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR must wait to merge after all dependency modal migration PRs have merged.

Summary

Removes the deprecated createModalLauncher function and all associated types from public/components/factory/modal.tsx. This is the final cleanup step in the CONSOLE-5012 modal migration effort.

Currently, createModalLauncher is replaced with a deprecated no-op stub so the build passes while consumer migration PRs are in flight. Once all dependency PRs merge and remove their usage, a follow-up commit will delete the stub entirely.

Changes

Removed from modal.tsx:

• createModal function
• createModalLauncher implementation (replaced with no-op stub)
• GetModalContainer type
• CreateModal type
• Unused imports: ReactDOM, Provider, Router, CompatRouter, store, history, PluginStoreProvider, pluginStore

Retained (still in use by migrated modals):

• ModalWrapper, ModalTitle, ModalBody, ModalFooter, ModalSubmitFooter
• ModalComponentProps

Temporarily retained as deprecated stubs (to be removed once all consumers are migrated):

• createModalLauncher (no-op)
• CreateModalLauncher type
• CreateModalLauncherProps type

Dependencies

PR	Status	Modals
#15932	Merged	delete-modal, delete-pvc, expand-pvc, clone-pvc, restore-pvc
#15939	Merged	configure-update-strategy, configure-ns-pull-secret, configure-cluster-upstream, managed-resource-save, remove-user
#15940	Merged	ResourceLimitsModal, ConfigureUnschedulableModal, DeletePDBModal
#15946	Merged	error-modal
#15990	Merged	PubSubModal, alert-routing, column-management, labels-modal, tags/annotations
#15997	Open	add-users, cluster-channel, cluster-more-updates, cluster-update, tolerations
#15968	Open	taints-modal + 9 OLM modals
#15935	Open	DeleteHPAModal, ConsolePluginModal
#15948	Open	confirm-modal
#16022	Open	DeleteResourceModal
#16063	Open	ExportApplicationModal, rollback-modal

Test plan

• All migration PRs merged first
• yarn build compiles without errors
• yarn lint passes
• yarn test passes
• No runtime errors when opening any modal in the console

Assisted by Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sg00dwin]

/retest-required

[openshift-ci]

@sg00dwin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	84fd938	link	true	/test e2e-gcp-console
ci/prow/images	84fd938	link	true	/test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.