OCPBUGS-74647: Fix referenceFor parameter in SubscriptionDetailsPage by rhamilto · Pull Request #15957 · openshift/console

rhamilto · 2026-01-29T14:53:36Z

After

Summary

Fixed incorrect parameter passed to referenceFor function in SubscriptionDetailsPage
Changed from kindObj to obj to align with proper referenceFor usage pattern

Details

In the customActionMenu prop of SubscriptionDetailsPage, the referenceFor function was being called with kindObj instead of obj. The referenceFor utility expects a resource object, not a kind/model object, so this change ensures the correct parameter is passed.

Test plan

Verify that the Subscription details page loads correctly
Verify that the action menu on the Subscription details page functions properly
Check that the correct context is passed to LazyActionMenu

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Fixed subscription action menu context handling to correctly reference individual objects, improving functionality and reliability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

The customActionMenu was incorrectly passing kindObj to referenceFor, when it should be passing obj. This aligns with the proper usage pattern for the referenceFor utility function. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

openshift-ci-robot · 2026-01-29T14:53:45Z

@rhamilto: This pull request references Jira Issue OCPBUGS-74647, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Fixed incorrect parameter passed to referenceFor function in SubscriptionDetailsPage

Changed from kindObj to obj to align with proper referenceFor usage pattern

Details

In the customActionMenu prop of SubscriptionDetailsPage, the referenceFor function was being called with kindObj instead of obj. The referenceFor utility expects a resource object, not a kind/model object, so this change ensures the correct parameter is passed.

Test plan

Verify that the Subscription details page loads correctly

Verify that the action menu on the Subscription details page functions properly

Check that the correct context is passed to LazyActionMenu

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-01-29T14:55:31Z

@rhamilto: This pull request references Jira Issue OCPBUGS-74647, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

After

Summary

Fixed incorrect parameter passed to referenceFor function in SubscriptionDetailsPage

Changed from kindObj to obj to align with proper referenceFor usage pattern

Details

In the customActionMenu prop of SubscriptionDetailsPage, the referenceFor function was being called with kindObj instead of obj. The referenceFor utility expects a resource object, not a kind/model object, so this change ensures the correct parameter is passed.

Test plan

Verify that the Subscription details page loads correctly

Verify that the action menu on the Subscription details page functions properly

Check that the correct context is passed to LazyActionMenu

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rhamilto · 2026-01-29T14:55:49Z

/cherrypick release-4.21 release-4.20

openshift-cherrypick-robot · 2026-01-29T14:55:52Z

@rhamilto: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.21 release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

coderabbitai · 2026-01-29T14:57:08Z

📝 Walkthrough

Walkthrough

The LazyActionMenu context key derivation in the subscription table row component has been updated to reference the actual subscription object instead of the kind model. The context mapping now uses referenceFor(obj) as the key rather than referenceFor(kindObj), ensuring the action menu operates with the specific object instance. No changes to control flow or surrounding logic are introduced.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title references fixing the referenceFor parameter in SubscriptionDetailsPage, which matches the core change: using referenceFor(obj) instead of referenceFor(kindObj) in SubscriptionTableRow's LazyActionMenu.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

jhadvig

Nice catch @rhamilto 🫡
/lgtm

openshift-ci · 2026-01-29T14:59:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [jhadvig,rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rhamilto · 2026-01-29T15:29:35Z

/retest

rhamilto · 2026-01-29T20:13:44Z

/retest

openshift-ci · 2026-01-30T01:25:28Z

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

rhamilto · 2026-01-30T13:39:10Z

/assign @yapei

XiyunZhao · 2026-02-02T01:44:44Z

/assign @XiyunZhao

XiyunZhao · 2026-02-03T08:08:47Z

/verified by @XiyunZhao
The action list functions correctly on the Subscription details page, and no issues were found during the execution of the following test plan

Verify that the Subscription details page loads correctly
Verify that the action menu on the Subscription details page functions properly
Check that the correct context is passed to LazyActionMenu

BTW, the action list layout issue (The action button is incorrectly rendered as an action menu, as shown in the PR screenshot) on the Subscription details page will be tracked in a separate bug @rhamilto

openshift-ci-robot · 2026-02-03T08:08:59Z

@XiyunZhao: This PR has been marked as verified by @XiyunZhao.

Details

In response to this:

/verified by @XiyunZhao
The action list functions correctly on the Subscription details page, and no issues were found during the execution of the following test plan

Verify that the Subscription details page loads correctly

Verify that the action menu on the Subscription details page functions properly

Check that the correct context is passed to LazyActionMenu

BTW, the action list layout issue (The action button is incorrectly rendered as an action menu, as shown in the PR screenshot) on the Subscription details page will be tracked in a separate bug @rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-02-03T13:16:01Z

@rhamilto: Jira Issue Verification Checks: Jira Issue OCPBUGS-74647
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-74647 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

After

Summary

Fixed incorrect parameter passed to referenceFor function in SubscriptionDetailsPage

Changed from kindObj to obj to align with proper referenceFor usage pattern

Details

In the customActionMenu prop of SubscriptionDetailsPage, the referenceFor function was being called with kindObj instead of obj. The referenceFor utility expects a resource object, not a kind/model object, so this change ensures the correct parameter is passed.

Test plan

Verify that the Subscription details page loads correctly

Verify that the action menu on the Subscription details page functions properly

Check that the correct context is passed to LazyActionMenu

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes

Fixed subscription action menu context handling to correctly reference individual objects, improving functionality and reliability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2026-02-03T13:16:47Z

@rhamilto: new pull request created: #15984

Details

In response to this:

/cherrypick release-4.21 release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rhamilto · 2026-02-03T13:24:27Z

BTW, the action list layout issue (The action button is incorrectly rendered as an action menu, as shown in the PR screenshot) on the Subscription details page will be tracked in a separate bug @rhamilto

🤦 Good catch, @XiyunZhao.

#15983

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 29, 2026

openshift-ci bot requested review from jhadvig, sg00dwin and yapei January 29, 2026 14:53

openshift-ci bot added component/olm Related to OLM approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 29, 2026

jhadvig approved these changes Jan 29, 2026

View reviewed changes

openshift-ci bot assigned jhadvig Jan 29, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2026

openshift-ci bot assigned yapei Jan 30, 2026

openshift-ci bot assigned XiyunZhao Feb 2, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 3, 2026

openshift-merge-bot bot merged commit c99c674 into openshift:main Feb 3, 2026
8 checks passed

openshift-cherrypick-robot mentioned this pull request Feb 3, 2026

[release-4.21] OCPBUGS-74998: Fix referenceFor parameter in SubscriptionDetailsPage #15984

Merged

rhamilto deleted the OCPBUGS-74647 branch February 3, 2026 13:18

Conversation

rhamilto commented Jan 29, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

After

Summary

Details

Test plan

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Jan 29, 2026

Summary

Details

Test plan

Uh oh!

openshift-ci-robot commented Jan 29, 2026

After

Summary

Details

Test plan

Uh oh!

rhamilto commented Jan 29, 2026

Uh oh!

openshift-cherrypick-robot commented Jan 29, 2026

Uh oh!

coderabbitai bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

jhadvig left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jan 29, 2026

Uh oh!

rhamilto commented Jan 29, 2026

Uh oh!

rhamilto commented Jan 29, 2026

Uh oh!

openshift-ci bot commented Jan 30, 2026

Uh oh!

rhamilto commented Jan 30, 2026

Uh oh!

XiyunZhao commented Feb 2, 2026

Uh oh!

XiyunZhao commented Feb 3, 2026

Uh oh!

openshift-ci-robot commented Feb 3, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 3, 2026

After

Summary

Details

Test plan

Summary by CodeRabbit

Uh oh!

openshift-cherrypick-robot commented Feb 3, 2026

Uh oh!

rhamilto commented Feb 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rhamilto commented Jan 29, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 29, 2026 •

edited

Loading