[release-4.21] OCPBUGS-76408: Move DynamicConfigurationManager back to TPNU#2703
[release-4.21] OCPBUGS-76408: Move DynamicConfigurationManager back to TPNU#2703Miciah wants to merge 2 commits intoopenshift:release-4.21from
Conversation
Revert "OCPBUGS-62987: Move DynamicConfigurationManager back to DevPreview" This reverts commit 25db151. This commit resolves OCPBUGS-67232. https://issues.redhat.com/browse/OCPBUGS-67232
* features/features.go (FeatureGateIngressControllerDynamicConfigurationManager): Add a link to the dynamic-config-manager enhancement proposal PR.
|
Hello @Miciah! Some important instructions when contributing to openshift/api: |
|
@Miciah: This pull request references Jira Issue OCPBUGS-76408, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
Review Summary by QodoMove IngressControllerDynamicConfigurationManager to TechPreviewNoUpgrade
WalkthroughsDescription• Move IngressControllerDynamicConfigurationManager from DevPreviewNoUpgrade to TechPreviewNoUpgrade • Add enhancement proposal PR link to feature gate definition • Update feature gate manifests to reflect new availability tier Diagramflowchart LR
A["IngressControllerDynamicConfigurationManager<br/>Feature Gate"] -->|"Change Tier"| B["DevPreviewNoUpgrade<br/>to<br/>TechPreviewNoUpgrade"]
A -->|"Add Reference"| C["Enhancement PR #1687"]
B -->|"Update"| D["Feature Gate Manifests"]
File Changes1. features/features.go
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
|
/jira refresh |
|
@Miciah: This pull request references Jira Issue OCPBUGS-76408, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
tested it with 4.21.0-0-2026-02-10-060753-test-ci-ln-cv0c42k-latest |
|
/label qe-approved |
|
@Miciah: This pull request references Jira Issue OCPBUGS-76408, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ShudiLi: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Any particular reason we want to backport TPNU re-enablement for 4.21? I don't have any problems with it, but it isn't something I see that often. The last time I saw this done was because we planned to backport enablement of a feature by default as well and backported to TPNU first as a way to test that enablement by default wouldn't cause issues. |
Some customers have been testing the feature in earlier OpenShift releases. We want to backport TPNU re-enablement in order to avoid confusion and avoid preventing these customers from testing in 4.21. #2552 was only expected to be a temporary measure to reduce noise in techpreview CI jobs, but we missed the window to re-enable before branch cut, thus the backport.
We are not currently planning to enable this feature by default in 4.21. |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Miciah: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is a manual cherry-pick of #2621.
Move DynamicConfigurationManager back to TPNU
Revert "OCPBUGS-62987: Move DynamicConfigurationManager back to DevPreview"
Add link to the dynamic-config-manager EP PR
Add a link to the dynamic-config-manager enhancement proposal PR.