Fix error handling for http errors everywhere#496
Open
px-amaac wants to merge 1 commit intoopenid:masterfrom
Open
Fix error handling for http errors everywhere#496px-amaac wants to merge 1 commit intoopenid:masterfrom
px-amaac wants to merge 1 commit intoopenid:masterfrom
Conversation
This commit adds check for response codes >= 400 and creates a new type of response for HTTP errors. Add tests for each area changed to handle a bad request http error.
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
============================================
- Coverage 83.71% 83.29% -0.42%
+ Complexity 479 477 -2
============================================
Files 42 42
Lines 2345 2364 +19
Branches 233 234 +1
============================================
+ Hits 1963 1969 +6
- Misses 299 314 +15
+ Partials 83 81 -2
Continue to review full report at Codecov.
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #496 +/- ##
=========================================
Coverage ? 83.29%
Complexity ? 477
=========================================
Files ? 42
Lines ? 2364
Branches ? 234
=========================================
Hits ? 1969
Misses ? 314
Partials ? 81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows in line with what was done for #144 following Android documentation and Recommendations from Oracle on handling http error responses. The change in #144 did not address this issue in other places of the library and could potentially throw json exception if error stream does not contain a valid JSON response.