of::filesystem PR

[dimitre]

relates to:
#6585

specifically:
#6585 (comment)

[dimitre]

This PR is finally complete,
it changes lots of files at once, so if we just left it open the tendency is conflicts arise from newer PRs like this : #7361

I think having to append .string() to convert a path to a string is a good change, so people can consciously convert the path to string, or u8string when needed

    of::filesystem::path path{u8"愛.txt"};
    std::u8string path_string{path.u8string()};

But I would like to invite others to give opinion on this: @artificiel @ofTheo @2bbb @NickHardeman

[2bbb]

hi! @dimitre

I think what we have explicit way to convert is good.

[ofTheo]

Thanks for those thoughts! One thing we could do if we want to merge this sooner is keep the string return types, merge this PR and put the path return types in a seperate PR. This would give a bit more time to think about strategy. I agree though this is ultimately the way to go, just don’t want to break a ton of addons, examples and projects without a bit more planning.

[dimitre]

Great @ofTheo I've just did that
converted all the return types to string.

[ofTheo]

Thanks @dimitre ! 🎉🎉🎉👏