refactor(deps): migrate tqdm from 4 to 4.67.3#2881
refactor(deps): migrate tqdm from 4 to 4.67.3#2881digital-wizard48 wants to merge 1 commit intoopenai:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf7093b84f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "inline-snapshot>=0.28.0", | ||
| "azure-identity >=1.14.1", | ||
| "types-tqdm > 4", | ||
| "types-tqdm>=4.67.1", |
There was a problem hiding this comment.
Keep types-tqdm constraint compatible with lockfile
Raising types-tqdm to >=4.67.1 makes pyproject.toml inconsistent with the checked-in requirements-dev.lock, which currently pins types-tqdm==4.67.0.20250809 (a lower version). This introduces an immediate dependency-set mismatch for workflows that validate or regenerate locks (for example the documented rye sync --all-features flow), so this bound should be relaxed or the lock updated in the same change.
Useful? React with 👍 / 👎.
Changes
pyproject.toml: Tightenedtqdmversion pin from> 4to>=4.67.1to track the target release; same fortypes-tqdm.src/openai/cli/_progress.py:import tqdm+tqdm.tqdm(...)to the idiomaticfrom tqdm import tqdmimport style, consistent with modern tqdm documentation recommendations.unit="B"totqdm()constructor so thatunit_scale=Truedisplays human-readable byte suffixes (KB, MB, GB) rather than bare scaled numbers — this was the intended behaviour for file-upload progress but the unit label was previously missing.meter.refresh()beforemeter.close()on upload completion so the bar renders its final 100% state before being torn down, preventing the progress bar from disappearing without showing completion.This PR was auto-generated by Gittensor upgrade bot using Claude AI