Skip to content

refactor(deps): migrate tqdm from 4 to 4.67.3#2881

Open
digital-wizard48 wants to merge 1 commit intoopenai:mainfrom
digital-wizard48:deps/upgrade-tqdm-4.67.3
Open

refactor(deps): migrate tqdm from 4 to 4.67.3#2881
digital-wizard48 wants to merge 1 commit intoopenai:mainfrom
digital-wizard48:deps/upgrade-tqdm-4.67.3

Conversation

@digital-wizard48
Copy link

Changes

  • pyproject.toml: Tightened tqdm version pin from > 4 to >=4.67.1 to track the target release; same for types-tqdm.
  • src/openai/cli/_progress.py:
    • Switched from import tqdm + tqdm.tqdm(...) to the idiomatic from tqdm import tqdm import style, consistent with modern tqdm documentation recommendations.
    • Added unit="B" to tqdm() constructor so that unit_scale=True displays human-readable byte suffixes (KB, MB, GB) rather than bare scaled numbers — this was the intended behaviour for file-upload progress but the unit label was previously missing.
    • Added meter.refresh() before meter.close() on upload completion so the bar renders its final 100% state before being torn down, preventing the progress bar from disappearing without showing completion.

This PR was auto-generated by Gittensor upgrade bot using Claude AI

@digital-wizard48 digital-wizard48 requested a review from a team as a code owner February 21, 2026 20:32
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf7093b84f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

"inline-snapshot>=0.28.0",
"azure-identity >=1.14.1",
"types-tqdm > 4",
"types-tqdm>=4.67.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep types-tqdm constraint compatible with lockfile

Raising types-tqdm to >=4.67.1 makes pyproject.toml inconsistent with the checked-in requirements-dev.lock, which currently pins types-tqdm==4.67.0.20250809 (a lower version). This introduces an immediate dependency-set mismatch for workflows that validate or regenerate locks (for example the documented rye sync --all-features flow), so this bound should be relaxed or the lock updated in the same change.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants