Add tools/format.sh which formats all files automatically.#14
Merged
g-easy merged 4 commits intoopen-telemetry:masterfrom Dec 19, 2019
Merged
Add tools/format.sh which formats all files automatically.#14g-easy merged 4 commits intoopen-telemetry:masterfrom
g-easy merged 4 commits intoopen-telemetry:masterfrom
Conversation
Uses clang-format, cmake-format, and buildifier.
g-easy
requested review from
jmacd,
maxgolov,
reyang,
rnburn and
tigrannajaryan
as code owners
rnburn
approved these changes
Dec 17, 2019
Contributor
Author
|
Ryan, can you try this script on your PR #13? Especially cmake-format and buildifier. :) |
Contributor
Author
|
@maxgolov what do you think? This kind of duplicates In particular, I'd like something more automated than |
rnburn
reviewed
Dec 17, 2019
Contributor
|
I got this error when I ran on os x |
Contributor
Author
|
Looks like BSD vs GNU sed. |
Also if clang-format-8 doesn't exist, fall back to clang-format.
Contributor
Author
|
Please try again. :) |
jmacd
approved these changes
Dec 17, 2019
Contributor
|
Worked! |
Contributor
Author
|
Thank you for your patience, and testing this on OSX which I didn't have access to. I think I need one more approval to merge. |
jmacd
approved these changes
Dec 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses clang-format, cmake-format, and buildifier.