Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
openmetadata-mcp/src/main/java/org/openmetadata/mcp/tools/CreateMetricTool.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Vishnuujain <Vishnuujain@users.noreply.github.com>
Code Review ✅ Approved 1 resolved / 1 findingsWell-structured CreateMetricTool implementation following established GlossaryTool patterns. The previous unchecked cast issue has been fixed with proper instanceof guards on all parameters. Logging improvements in CommonUtils and DefaultToolContext are solid additions. ✅ 1 resolved✅ Edge Case: Unchecked casts on required params may throw ClassCastException
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
Changes have been cherry-picked to the 1.12.2 branch. |
* feat(mcp): add create_metric tool to OpenMetadata MCP server * fix(mcp): make metricExpression required in create_metric tool * fix(mcp): add domains field to create_metric tool * fix(mcp): improve patch_entity field path guidance * style(mcp): apply spotless formatting * fix: add type checking for required params in CreateMetricTool Co-authored-by: Vishnuujain <Vishnuujain@users.noreply.github.com> --------- Co-authored-by: Gitar <noreply@gitar.ai> Co-authored-by: Vishnuujain <Vishnuujain@users.noreply.github.com> (cherry picked from commit a6556b9)
Describe your changes:
Fixes #26016
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
CreateMetricToolto enable AI agents to create Metric entities with configurable expressions (SQL, Python, Java, JavaScript), types, granularities, and units of measurementDefaultToolContextdispatcher and added comprehensive parameter definitions totools.jsonwith validation guidanceCommonUtilsandDefaultToolContextwith structured message placeholders and full exception contextThis will update automatically on new commits.