Skip to content

bump pybind11_json to 0.2.15 and remove one test skip given a segfault was fixed. closes #319 #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slayoo merged 2 commits into from
Dec 10, 2024
Merged

bump pybind11_json to 0.2.15 and remove one test skip given a segfault was fixed. closes #319 #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d85c54
bump pybind11_json to 0.2.15 and remove one test skip given a segfaul…
slayoo Dec 9, 2024
4cc22e8
add skip for ARM64
slayoo Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gitmodules/pybind11_json
Open in desktop
Submodule pybind11_json updated 12 files
+8 −57 .github/workflows/main.yml
+1 −0 .gitignore
+2 −2 CMakeLists.txt
+5 −14 README.md
+0 −11 dev-environment.yml
+30 −5 include/pybind11_json/pybind11_json.hpp
+3,249 −0 pixi.lock
+56 −0 pixi.toml
+1 −1 test/CMakeLists.txt
+1 −1 test/copyGTest.cmake.in
+2 −2 test/downloadGTest.cmake.in
+19 −0 test/test_pybind11_json.cpp
15 changes: 10 additions & 5 deletions tests/test_aero_mode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,16 +291,21 @@ def test_ctor_fails_with_nonunique_mass_fracs():
assert str(exc_info.value) == "mass_frac keys must be unique"

@staticmethod
def test_segfault_case(): # TODO #319
pytest.skip()

@pytest.mark.skipif(platform.machine() == "arm64", reason="TODO #348")
def test_fixed_segfault_case_on_circular_reference():
# arrange
aero_data = ppmc.AeroData(AERO_DATA_CTOR_ARG_MINIMAL)
fishy_ctor_arg = copy.deepcopy(AERO_MODE_CTOR_LOG_NORMAL)
fishy_ctor_arg["test_mode"]["mass_frac"].append(
fishy_ctor_arg["test_mode"]["mass_frac"]
)
print(fishy_ctor_arg)
ppmc.AeroMode(aero_data, fishy_ctor_arg)

# act
with pytest.raises(TypeError) as exc_info:
ppmc.AeroMode(aero_data, fishy_ctor_arg)

# assert
assert "incompatible constructor arguments" in str(exc_info.value)

@staticmethod
@pytest.mark.skipif(platform.machine() == "arm64", reason="TODO #348")
Expand Down
Loading