Open
Conversation
jamietanna
force-pushed
the
feat/skipper
branch
from
96b28bd to
7486a46
Compare
As noted in #63, an equivalent to Echo's `Skipper` would allow for middleware users to opt-out of validation in a more straightforward way. In a slightly different implementation to our `echo-middleware`, this does not allow the `Skipper` to consume the body of the original request, and instead duplicates it for the `Skipper`, and the other uses of it. Closes #63.
jamietanna
force-pushed
the
feat/skipper
branch
from
7486a46 to
ff1f0eb
Compare
Member
Author
|
@GreyXor how does this look? |
LGTM! :) |
| r2 := r.Clone(r.Context()) | ||
|
|
||
| if r.Body != nil { | ||
| bodyBytes, err := io.ReadAll(r.Body) |
Member
There was a problem hiding this comment.
I have to think about this, because by reading the body, you are assuming that people aren't streaming a gigantic request. This choice has some memory usage and deserialization consequences.
I don't think we should copy the request, and pass the original request into the skipper. The user can decide whether or not to read the body; they may be able to decide if skipping is needed based on headers alone.
What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #63, an equivalent to Echo's
Skipperwould allow formiddleware users to opt-out of validation in a more straightforward way.
In a slightly different implementation to our
echo-middleware, thisdoes not allow the
Skipperto consume the body of the originalrequest, and instead duplicates it for the
Skipper, and the other usesof it.