Skip to content

Conversation

@Moshyfawn
Copy link

Search scope is now part of the q=param using operator syntax like ?q=description:core instead of separate scope= param in preparation for multi-scope search; currently left in single-scope mode. To keep the scope of this PR small, I wired the filter params to be active 1 at a time as multi scope search requires a bigger UI overhaul. buildSearchQuery exists solely for ease of enabling multi args search in the future.

I decided against short keywords in the URL for now, although could adopt kw, desc etc.

Closes #761

Search scope is now part of the q= param using operator syntax like ?q=description:core instead of separate scope= param in preparation for multi-scope search; currently left in single-scope mode
@vercel
Copy link

vercel bot commented Feb 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 3, 2026 0:10am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 3, 2026 0:10am
npmx-lunaria Ignored Ignored Feb 3, 2026 0:10am

Request Review

@Moshyfawn
Copy link
Author

https://npmx-my2gci1n9-poetry.vercel.app/@vueuse is a good test case

@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

This change refactors the search functionality within the organisation page component. It introduces a helper function to construct search queries from text, scope, and keywords components. The implementation adds query parsing logic to establish an initial search scope, extends type imports to include SearchScope, and modifies the initial filters to incorporate the determined scope. A watcher is introduced to reset keywords when the search scope changes. The URL update mechanism is reworked to rename the parameter from filter to q and to construct queries using the new helper function whilst tracking scope changes.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The PR description clearly explains the change to embed search scope as an operator in the URL query parameter instead of a separate scope parameter.
Linked Issues check ✅ Passed The PR implementation addresses all coding requirements from issue #761: restores scoped search functionality, supports multiple scopes (name, description, keywords), implements operator syntax in query parameter, and maintains keywords search.
Out of Scope Changes check ✅ Passed All changes are focused on refactoring the search query parameter handling in the organisations page component to embed scope operators; no unrelated modifications detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Failure to add the new IP will result in interrupted reviews.


Comment @coderabbitai help to get the list of available commands and usage tips.

@Moshyfawn Moshyfawn marked this pull request as draft February 3, 2026 12:05
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Scoped search in org search

1 participant