Skip to content

chore: change default accent color#1678

Merged
danielroe merged 5 commits intonpmx-dev:mainfrom
alexdln:chore/change-default-accent
Feb 26, 2026
Merged

chore: change default accent color#1678
danielroe merged 5 commits intonpmx-dev:mainfrom
alexdln:chore/change-default-accent

Conversation

@alexdln
Copy link
Member

@alexdln alexdln commented Feb 26, 2026

🧭 Context

The site is too uniform and lacks color. Configure sky as the default accent color. The contrast option remains, but as an option in the settings.

Also fixed the default state detection and hydration of bg-theme-picker

Also improved the contrast of accent color for all options so that they at least pass the minimum level.

@vercel
Copy link

vercel bot commented Feb 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 26, 2026 8:35pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 26, 2026 8:35pm
npmx-lunaria Ignored Ignored Feb 26, 2026 8:35pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a86ff0 and 7d602d9.

📒 Files selected for processing (2)
  • app/assets/main.css
  • shared/utils/constants.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/assets/main.css

📝 Walkthrough

Walkthrough

This pull request updates theme accent swatches and default accents across the app: modifies CSS variables in app/assets/main.css (adds a neutral swatch, new sky values, and adjusts dark/light accent oklch tokens), updates ACCENT_COLORS in shared/utils/constants.ts to include neutral and revised swatch values, refactors app/components/Settings/AccentColorPicker.vue to use a default accent id ('sky') and render the neutral option as an inline indicator, and adjusts app/components/Settings/BgThemePicker.vue to treat 'neutral' as the default theme id for prehydration and checked-state logic.

Possibly related PRs

Suggested labels

front, a11y

Suggested reviewers

  • danielroe
  • whitep4nth3r
  • RamaHerbin
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, detailing the main objectives: setting sky as default accent colour, moving contrast to settings, fixing bg-theme-picker hydration, and improving accent contrast.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa62d11 and 8b3c1ba.

📒 Files selected for processing (4)
  • app/assets/main.css
  • app/components/Settings/AccentColorPicker.vue
  • app/components/Settings/BgThemePicker.vue
  • shared/utils/constants.ts

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b3c1ba and 5a86ff0.

📒 Files selected for processing (2)
  • app/assets/main.css
  • shared/utils/constants.ts

@danielroe danielroe added this pull request to the merge queue Feb 26, 2026
Merged via the queue into npmx-dev:main with commit 1d4dbd4 Feb 26, 2026
17 checks passed
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants