chore: change default accent color#1678
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis pull request updates theme accent swatches and default accents across the app: modifies CSS variables in app/assets/main.css (adds a neutral swatch, new sky values, and adjusts dark/light accent oklch tokens), updates ACCENT_COLORS in shared/utils/constants.ts to include neutral and revised swatch values, refactors app/components/Settings/AccentColorPicker.vue to use a default accent id ('sky') and render the neutral option as an inline indicator, and adjusts app/components/Settings/BgThemePicker.vue to treat 'neutral' as the default theme id for prehydration and checked-state logic. Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
app/assets/main.cssapp/components/Settings/AccentColorPicker.vueapp/components/Settings/BgThemePicker.vueshared/utils/constants.ts
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
🧭 Context
The site is too uniform and lacks color. Configure sky as the default accent color. The contrast option remains, but as an option in the settings.
Also fixed the default state detection and hydration of bg-theme-picker
Also improved the contrast of accent color for all options so that they at least pass the minimum level.