Skip to content

fix(ui): fix missing icons#1484

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
wojtekmaj:missing-icons
Feb 13, 2026
Merged

fix(ui): fix missing icons#1484
danielroe merged 1 commit intonpmx-dev:mainfrom
wojtekmaj:missing-icons

Conversation

@wojtekmaj
Copy link
Contributor

In #1454, Carbon icons were removed. This caused a conflict when later that day #1417 was merged. Additionally, in #1454 some non-existing icons were used, like x-filled, or check-filled.

In npmx-dev#1454, Carbon icons were removed. This caused a conflict when later that day npmx-dev#1417 was merged. Additionally, in npmx-dev#1454 some non-existing icons were used, like x-filled, or check-filled.
Copilot AI review requested due to automatic review settings February 13, 2026 23:14
@vercel
Copy link

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 13, 2026 11:16pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 13, 2026 11:16pm
npmx-lunaria Ignored Ignored Feb 13, 2026 11:16pm

Request Review

@wojtekmaj
Copy link
Contributor Author

@essenmitsosse FYI :)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes icon-related issues introduced when PR #1454 removed Carbon icons and conflicted with PR #1417. It replaces non-existent Lucide icon names (check-filled, x-filled) with correct ones (check, x) and completes the transition from Carbon to Lucide icons for several remaining instances.

Changes:

  • Fixed non-existent icon names (check-filled → check, x-filled → x) across multiple components
  • Replaced remaining Carbon icon references with Lucide equivalents
  • Minor whitespace cleanup (removed trailing spaces)

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
app/pages/package/[[org]]/[name].vue Replaced Carbon checkmark/copy icons with Lucide equivalents
app/components/Readme.vue Replaced Carbon link icon with Lucide link icon
app/components/Package/Versions.vue Replaced Carbon information icon with Lucide info icon
app/components/Package/TrendsChart.vue Replaced Carbon accessibility icon with Lucide person-standing and removed trailing whitespace
app/components/Package/ClaimPackageModal.vue Fixed non-existent check-filled and x-filled icons to use correct check and x icons
app/components/Org/OperationsQueue.vue Fixed non-existent check-filled and x-filled icons in status indicators and operation results

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2026

📝 Walkthrough

Walkthrough

This pull request updates UI icons across six Vue components to use outline variants instead of filled variants, and replaces Carbon icon references with Lucide icon equivalents in specific instances. Changes include updating status icons in OperationsQueue.vue, modal icons in ClaimPackageModal.vue, a legend icon in TrendsChart.vue, information and link icons in Versions.vue and Readme.vue respectively, and a copy-state icon in the package detail page. No logic or control flow modifications are included.

Possibly related PRs

  • refactor: replace carbon icons #1454: Large refactor replacing Carbon icons with Lucide/simple-icons across the same set of components (OperationsQueue.vue, ClaimPackageModal.vue, TrendsChart.vue, Versions.vue, Readme.vue), making this a follow-up or related icon styling update.

Suggested labels

front

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately explains the context and purpose of the changes, referencing specific PRs and detailing the icon migration and conflict resolution.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Org/OperationsQueue.vue 50.00% 1 Missing ⚠️
app/pages/package/[[org]]/[name].vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Feb 13, 2026
Merged via the queue into npmx-dev:main with commit 9fbdb32 Feb 13, 2026
23 checks passed
@alexdln
Copy link
Member

alexdln commented Feb 13, 2026

Goddess, we're still updating too fast 😅

@wojtekmaj you are great, thanks for checking and fixing so quickly ❤️

WarningImHack3r pushed a commit to WarningImHack3r/npmx.dev that referenced this pull request Feb 14, 2026
@wojtekmaj wojtekmaj deleted the missing-icons branch February 14, 2026 00:38
@essenmitsosse
Copy link
Contributor

@wojtekmaj oh shit thank you for fixing this. I kind of worried something like this would happen but hopped it wouldn't. Some of the fixes after the initial PR were too rushed to get it out before the break. Thanks for fixing my mess!

@wojtekmaj
Copy link
Contributor Author

@essenmitsosse Absolutely no worries. That's why we're a team :) I'll mess something up next week 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants