Conversation
In npmx-dev#1454, Carbon icons were removed. This caused a conflict when later that day npmx-dev#1417 was merged. Additionally, in npmx-dev#1454 some non-existing icons were used, like x-filled, or check-filled.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
@essenmitsosse FYI :) |
There was a problem hiding this comment.
Pull request overview
This PR fixes icon-related issues introduced when PR #1454 removed Carbon icons and conflicted with PR #1417. It replaces non-existent Lucide icon names (check-filled, x-filled) with correct ones (check, x) and completes the transition from Carbon to Lucide icons for several remaining instances.
Changes:
- Fixed non-existent icon names (check-filled → check, x-filled → x) across multiple components
- Replaced remaining Carbon icon references with Lucide equivalents
- Minor whitespace cleanup (removed trailing spaces)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/pages/package/[[org]]/[name].vue | Replaced Carbon checkmark/copy icons with Lucide equivalents |
| app/components/Readme.vue | Replaced Carbon link icon with Lucide link icon |
| app/components/Package/Versions.vue | Replaced Carbon information icon with Lucide info icon |
| app/components/Package/TrendsChart.vue | Replaced Carbon accessibility icon with Lucide person-standing and removed trailing whitespace |
| app/components/Package/ClaimPackageModal.vue | Fixed non-existent check-filled and x-filled icons to use correct check and x icons |
| app/components/Org/OperationsQueue.vue | Fixed non-existent check-filled and x-filled icons in status indicators and operation results |
📝 WalkthroughWalkthroughThis pull request updates UI icons across six Vue components to use outline variants instead of filled variants, and replaces Carbon icon references with Lucide icon equivalents in specific instances. Changes include updating status icons in OperationsQueue.vue, modal icons in ClaimPackageModal.vue, a legend icon in TrendsChart.vue, information and link icons in Versions.vue and Readme.vue respectively, and a copy-state icon in the package detail page. No logic or control flow modifications are included. Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Goddess, we're still updating too fast 😅 @wojtekmaj you are great, thanks for checking and fixing so quickly ❤️ |
|
@wojtekmaj oh shit thank you for fixing this. I kind of worried something like this would happen but hopped it wouldn't. Some of the fixes after the initial PR were too rushed to get it out before the break. Thanks for fixing my mess! |
|
@essenmitsosse Absolutely no worries. That's why we're a team :) I'll mess something up next week 😁 |
In #1454, Carbon icons were removed. This caused a conflict when later that day #1417 was merged. Additionally, in #1454 some non-existing icons were used, like x-filled, or check-filled.