Skip to content

Comments

refactor: use buttons and links components in account menu#1451

Merged
danielroe merged 7 commits intonpmx-dev:mainfrom
essenmitsosse:refactor-buttons-and-links-in-account-menu
Feb 13, 2026
Merged

refactor: use buttons and links components in account menu#1451
danielroe merged 7 commits intonpmx-dev:mainfrom
essenmitsosse:refactor-buttons-and-links-in-account-menu

Conversation

@essenmitsosse
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 13, 2026 0:49am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 13, 2026 0:49am
npmx-lunaria Ignored Ignored Feb 13, 2026 0:49am

Request Review

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2026

📝 Walkthrough

Walkthrough

This pull request updates icon references and refactors component usage across multiple Vue files. The Bluesky icon is changed from the simple-icons set to the carbon logo set in AppHeader.vue and CallToAction.vue. The Filter/Panel.vue component's radio button selection mechanism is refactored to use TagRadioButton components with v-model binding instead of manual button markup and click handlers. Multiple components (AccountMenu.client.vue, AuthModal.client.vue, ConnectorModal.vue) replace native HTML button and anchor elements with ButtonBase and LinkBase components, introducing a new classicon prop to ButtonBase for icon handling.

Possibly related PRs

Suggested reviewers

  • danielroe
  • alexdln
🚥 Pre-merge checks | ✅ 1 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request has no description provided by the author, making it impossible to assess alignment between stated intent and actual changes. Add a clear pull request description explaining the refactoring objectives, such as why ButtonBase and LinkBase components are being adopted and any expected benefits or migration notes.
✅ Passed checks (1 passed)
Check name Status Explanation
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
app/components/Header/AccountMenu.client.vue (1)

86-86: Consider using colon syntax for UnoCSS icons.

The icon classes use dash-separated syntax (e.g., i-carbon-terminal, i-carbon-chevron-down). For performance optimisation with UnoCSS preset-icons, prefer the colon syntax (e.g., i-carbon:terminal, i-carbon:chevron-down). This helps UnoCSS resolve the collection directly.

Based on learnings: "In Vue components, use colon syntax for UnoCSS preset-icons (e.g., i-carbon:checkmark instead of i-carbon-checkmark)."

Also applies to: 104-104, 115-116, 164-164, 206-206, 232-237, 258-258

@essenmitsosse
Copy link
Contributor Author

Sorry the Panel.vue part wasn't supposed to be in the PR. Reverted it.

@danielroe danielroe added this pull request to the merge queue Feb 13, 2026
Merged via the queue into npmx-dev:main with commit a5b2e9c Feb 13, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants