Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
e4b98d0 to
b46458d
Compare
📝 WalkthroughWalkthroughThe Readme.vue selector for external links now excludes anchors that contain an img descendant ( Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
server/utils/readme.ts (1)
504-534:⚠️ Potential issue | 🔴 CriticalMissing href assignment after resolution.
resolvedHrefis computed and used for playground matching and external link detection, but it's never assigned back toattribs.href. The output will retain the original unresolved href, which means:
- Anchor links won't get the
user-content-prefix- Relative URLs won't be resolved to CDN/raw URLs
- npmjs.com redirects won't be applied
🐛 Suggested fix
const resolvedHref = resolveUrl(attribs.href, packageName, repoInfo) + attribs.href = resolvedHref const provider = matchPlaygroundProvider(resolvedHref)
🧹 Nitpick comments (1)
server/utils/readme.ts (1)
78-84: Minor: Capitalisation inconsistency in provider name."Typescript" should be "TypeScript" (capital S) to match the official branding.
✏️ Suggested fix
{ id: 'typescript-playground', - name: 'Typescript Playground', + name: 'TypeScript Playground', domains: ['typescriptlang.org'], path: '/play', icon: 'typescript', },
Head branch was pushed to by a user without write access
b46458d to
7bef5a1
Compare
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
As @alexdln noted: HTML links in markdown to npmjs.com where not converted to local links. In fact all most all processing for links only worked on markdown links. This moves the link transformation and analysis (for TOC + playground) to
sanitize-htmlwhich parses the HTML after the Markdown has been converted to HTML, to have a single implementation for all links.Addtional things: