-
-
Notifications
You must be signed in to change notification settings - Fork 243
fix: surfacing 429s as not found to users #1200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis PR implements rate-limit handling for npm searches. The Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
thank you ❤️ |
|
Thanks for your first contribution, @johnnyreilly! 💫 We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role. |
Resolves: #1174
This is a speculative PR which changes the approach to surface an explicit "Hit npm rate limit, try again in a moment" message when 429s happen. I wondered if this would be useful?
No worries if it's not - but I thought I'd share the idea! This doesn't contain all i18n locales. If the approach is helpful I think with AIs help I can probably provide that.
PS first time doing any Vue / Nuxt - please bear with my mistakes!