Skip to content

Comments

fix: regression of readme heading#1037

Merged
serhalp merged 1 commit intonpmx-dev:mainfrom
garthdw:fix/readme-heading-regression
Feb 6, 2026
Merged

fix: regression of readme heading#1037
serhalp merged 1 commit intonpmx-dev:mainfrom
garthdw:fix/readme-heading-regression

Conversation

@garthdw
Copy link
Contributor

@garthdw garthdw commented Feb 5, 2026

Fix regression for #881

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Error Error Feb 5, 2026 7:59pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 5, 2026 7:59pm
npmx-lunaria Ignored Ignored Feb 5, 2026 7:59pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

The changes adjust presentational styling in the package page's Readme section. The container's bottom margin is reduced from mb-4 to mb-3, and the readme link anchor element has its vertical and horizontal padding (py-4 px-2) removed whilst retaining other styling properties. These are purely spacing and padding adjustments with no functional or behavioural modifications.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly references a specific pull request regression fix, directly relating to the changeset which adjusts spacing/padding in the package readme section.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@trueberryless
Copy link
Contributor

I'm confused. Weren't these changes already made in #881?
Or did they get reverted by accident? Do you have a link to when they were change the last time? That would be awesome 🙌

@garthdw
Copy link
Contributor Author

garthdw commented Feb 5, 2026

I'm confused. Weren't these changes already made in #881?

Or did they get reverted by accident? Do you have a link to when they were change the last time? That would be awesome 🙌

It appears to have been reverted as part of #904 (comment)

Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense then 👍
Could you update the PR description to include this link to your comment as well, that would make it clearer 🙏

LGTM then 🥳

@serhalp serhalp added this pull request to the merge queue Feb 6, 2026
Merged via the queue into npmx-dev:main with commit 6acba09 Feb 6, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants