build: use path-ignore in GHA coverage-windows.yml#61811
build: use path-ignore in GHA coverage-windows.yml#61811nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
|
Review requested:
|
A test failure doesn't mark the job as failure, no? In this case, is it worth it? I don't think changes on those files would affect the coverage, but could be wrong |
Eh, yes, you're right that the coverage job will not be marked failure if the test fails: But it will be marked as failure if the build fails. |
|
For reference, we used to have a dedicated |
|
The reason in #54662 that |
|
Landed in 94b1f66 |
PR-URL: #61811 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Use similar
paths-ignorein other GHA jobs like.github/workflows/test-macos.ymlto ignore certain changes that do not have effect on builds.This allows changes to
configure.py,node.gyp, orsrc/inspector/node_protocol.pdl, etc, to be tested on GHA windows.For example, windows GHA was not triggered on #61806.