Skip to content

build: use path-ignore in GHA coverage-windows.yml#61811

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
legendecas:gha-win
Feb 18, 2026
Merged

build: use path-ignore in GHA coverage-windows.yml#61811
nodejs-github-bot merged 1 commit intonodejs:mainfrom
legendecas:gha-win

Conversation

@legendecas
Copy link
Member

@legendecas legendecas commented Feb 13, 2026

Use similar paths-ignore in other GHA jobs like .github/workflows/test-macos.yml to ignore certain changes that do not have effect on builds.

This allows changes to configure.py, node.gyp, or src/inspector/node_protocol.pdl, etc, to be tested on GHA windows.

For example, windows GHA was not triggered on #61806.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Feb 13, 2026
@legendecas legendecas changed the title build: run GHA windows test when gyp file changes build: use path-ignore in GHA coverage-windows.yml Feb 13, 2026
@aduh95
Copy link
Contributor

aduh95 commented Feb 13, 2026

This allows changes to configure.py, node.gyp, or src/inspector/node_protocol.pdl, etc, to be tested on GHA windows.

A test failure doesn't mark the job as failure, no? In this case, is it worth it? I don't think changes on those files would affect the coverage, but could be wrong

@legendecas
Copy link
Member Author

A test failure doesn't mark the job as failure, no? In this case, is it worth it? I don't think changes on those files would affect the coverage, but could be wrong

Eh, yes, you're right that the coverage job will not be marked failure if the test fails:

run: ./vcbuild.bat noprojgen nobuild test-ci-js; node -e 'process.exit(0)'

But it will be marked as failure if the build fails.

@aduh95
Copy link
Contributor

aduh95 commented Feb 18, 2026

For reference, we used to have a dedicated build-windows workflow but it was removed in #54662

@legendecas
Copy link
Member Author

The reason in #54662 that build-windows was removed was that the build-windows was identical to coverage-windows. So it does not seem to me that the ignore pattern was an concern?

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 18, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 18, 2026
@nodejs-github-bot nodejs-github-bot merged commit 94b1f66 into nodejs:main Feb 18, 2026
22 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 94b1f66

@legendecas legendecas deleted the gha-win branch February 18, 2026 16:19
aduh95 pushed a commit that referenced this pull request Feb 19, 2026
PR-URL: #61811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments