deps: update nbytes to 0.1.3 for HexEncode perf#61609
deps: update nbytes to 0.1.3 for HexEncode perf#61609ChALkeR wants to merge 1 commit intonodejs:mainfrom
Conversation
|
Review requested:
|
1599c68 to
fe74ddb
Compare
|
nbytes PR: nodejs/nbytes#12 |
This comment was marked as outdated.
This comment was marked as outdated.
|
Third Benchmark CI run, ternary: |
3d93f06 to
11672ec
Compare
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/22149104377 |
|
Note: this doesn't bump the version in header, like #61270 didn't bump it from 0.1.1 to 0.1.2 So it's still set there at 0.1.1 |
Did you use |
|
@aduh95 No, I didn't #61270 is from the bot though and it didn't update the version from 0.1.1 to 0.1.2 |
Refs: nodejs/nbytes#12
Refs: nodejs/nbytes#13
Fixes the hex part of #60249 and improves
Buffer#toString('hex')2-4xIn local tests on a MacBook, this improves
.toString('hex')throughput from ~2.24 GiB/sto ~9.53 GiB/son ~80 KiB chunksFor comparison,
Uint8Array#toHex()shows3.28 GiB/s.Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1790/console