[v25.x] v8: changing total_allocated_bytes to avoid ABI changes

[caiolima]

As noted by @targos in #60429 (comment), the implementation of total_allocated_bytes changes the ABI. This PR changes original V8 implementation to a version where there's no addition of HeapStatistics::total_allocated_bytes_ to V8's HeapStatistics, and instead we get such values using Isolate::GetTotalAllocatedBytes. This also changes code introduced by #60573 to use this new API on either v8.getHeapStatistics() and Worker::GetHeapStatistics. The goal here is to make total_allocated_bytes back portable to previous versions, but keeping the v8.getHeapStatistics() API stable once users transition from v25 to future versions. It also solves the ABI change introduced by https://github.com/nodejs/node/pull/60429/files

There's also a fix on documentation text with missing . and updating the code snippet to include total_allocated_bytes on output.

[nodejs-github-bot]

Review requested:

• @nodejs/gyp
• @nodejs/security-wg
• @nodejs/v8-update

[RafaelGSS]

LGTM.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70277/

[caiolima]

Hi all, could someone help me trigger CI again, please?

[caiolima]

Up

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70419/

[caiolima]

I'm getting permission errors to look what is failing on CI. Probably it already expired. Does any of you have permission to see what's failing?

[github-actions]

Failed to start CI

   ⚠  Commits were pushed since the last approving review:
   ⚠  - tools: fix linter warning in `test-shared.yml`
   ⚠  - doc: correct concurrency wording in test() documentation
   ⚠  - build: fix OpenSSL version parsing for OpenSSL < 3
   ⚠  - test_runner: simplify code and make it more consistent
   ⚠  - repl: tab completion targets `` instead of `new `
   ⚠  - tools: bump js-yaml from 4.1.0 to 4.1.1 in /tools/lint-md
   ⚠  - deps: update brotli to 1.2.0
   ⚠  - deps: upgrade npm to 11.6.3
   ⚠  - tools: dump config.gypi as json
   ⚠  - lib: prefer `call()` over `apply()` if argument list is not array
   ⚠  - src: rename config file testRunner to test
   ⚠  - src: add test flag to config file
   ⚠  - src: add permission flag to config file
   ⚠  - doc: fix webstorage config file property
   ⚠  - src: implicitly enable namespace in config
   ⚠  - doc: keep sidebar module visible when navigating docs
   ⚠  - deps: update sqlite to 3.51.0
   ⚠  - deps: add temporal_rs 0.1.0
   ⚠  - build: add temporal_capi gyp
   ⚠  - test: add basic temporal presence check
   ⚠  - build: ignore built-in temporal when building with shared lib
   ⚠  - url: remove array.reduce usage
   ⚠  - test_runner: fix line feed escaping in JUnit
   ⚠  - test: use `RegExp.escape` to improve test reliability
   ⚠  - doc: add additional codemods for deprecation
   ⚠  - test: prefer major GC in cppgc-object teardown
   ⚠  - test: ensure assertions are reached on more tests
   ⚠  - test: ensure assertions are reached on more tests
   ⚠  - test: ensure assertions are reached on more tests
   ⚠  - test: ensure assertions are reached on more tests
   ⚠  - tools: add temporal updater
   ⚠  - test: replace deprecated regex test assertions in http trailers test
   ⚠  - doc: add fullName property to SuiteContext
   ⚠  - test: add lint rule to forbid use of `assert.ok(/regex/.test(…))`
   ⚠  - events: repurpose `events.listenerCount()` to accept EventTargets
   ⚠  - src: mark unused private field as such
   ⚠  - src: simply uint32 to string as it must not fail
   ⚠  - lib: add lint rules for reflective function calls
   ⚠  - test: ensure assertions are reached on all tests
   ⚠  - test: fix debug test crashes caused by sea tests
   ⚠  - doc: mark module.register as active development
   ⚠  - util: safely inspect getter errors whose message throws
   ⚠  - node-api: fix data race and use-after-free in napi_threadsafe_function
   ⚠  - src: handle indexed properties in `process.env`
   ⚠  - deps: upgrade npm to 11.6.4
   ⚠  - doc: fix typos in changelogs
   ⚠  - doc: correct 'event handle' to 'event handler' in Utf8Stream drop event
   ⚠  - test: skip failing tests when compiled without amaro
   ⚠  - doc: update debuglog examples to use 'foo-bar' instead of 'foo'
   ⚠  - src: use static_cast instead of C-style cast
   ⚠  - test: fix embedtest in debug windows
   ⚠  - doc: correct spelling in BUILDING.md
   ⚠  - doc: replace column with columnNumber in example of `util.getCallSites`
   ⚠  - deps: update corepack to 0.34.5
   ⚠  - test: use `assert.match` for non-literal regexp tests
   ⚠  - doc: show the use of string expressions in the SQLTagStore example
   ⚠  - lib,test: fix jsdoc comments
   ⚠  - test: lint more `assert(regexp.test(...))` cases
   ⚠  - doc: clarify fileURLToPath security considerations
   ⚠  - util: improve textencoder encodeInto performance
   ⚠  - src: handle DER decoding errors from system certificates
   ⚠  - tools: don't fetch V8 deps in the source tree
   ⚠  - build: run embedtest with node_g when BUILDTYPE=Debug
   ⚠  - test: update WPT for WebCryptoAPI to 1e4933113d
   ⚠  - deps: update zlib to 1.3.1-63d7e16
   ⚠  - deps: update sqlite to 3.51.1
   ⚠  - deps,src: prepare for cpplint update
   ⚠  - tools: disable some new cpplint rules before update
   ⚠  - tools: update cpplint to 2.0.2
   ⚠  - tools: refloat 10 Node.js patches to cpplint.py
   ⚠  - src: fix off-thread cert loading in bundled cert mode
   ⚠  - test: skip SEA inspect test if inspector is not available
   ⚠  - tools: update ESLint dependencies
   ⚠  - tools: remove deprecated ESLint plugins
   ⚠  - tools: replace deprecated eslint-plugin-markdown
   ⚠  - doc: add missing `zstd` to mjs example of zlib
   ⚠  - benchmark: fix incorrect base64 input in byteLength benchmark
   ⚠  - tools: run tests `--without-amaro` on test-shared macOS
   ⚠  - stream: fix isErrored/isWritable for WritableStreams
   ⚠  - tools: enforce trailing commas in `test/sequential`
   ⚠  - tools: enforce trailing commas in `test/es-module`
   ⚠  - tools: ignore more paths in GHA CI
   ⚠  - util: assert getCallSites does not invoke Error.prepareStackTrace
   ⚠  - meta: bump peter-evans/create-pull-request from 7.0.8 to 7.0.9
   ⚠  - meta: bump actions/checkout from 5.0.1 to 6.0.0
   ⚠  - meta: bump github/codeql-action from 4.31.3 to 4.31.6
   ⚠  - meta: bump actions/setup-python from 6.0.0 to 6.1.0
   ⚠  - module: allow subpath imports that start with `#/`
   ⚠  - tools: bump mdast-util-to-hast from 13.2.0 to 13.2.1 in /tools/doc
   ⚠  - src: implement Windows-1252 encoding support and update related tests
   ⚠  - http2,zlib: prefer `call()` over `apply()` if argument list is not array
   ⚠  - test: improve config-file permission test coverage
   ⚠  - esm: improve error messages for ambiguous module syntax
   ⚠  - doc: add File modes cross-references in fs methods
   ⚠  - tools: add some options and comments to `shell.nix`
   ⚠  - test: skip tests not passing without `NODE_OPTIONS` support
   ⚠  - deps: V8: cherry-pick 72b0e27bd936
   ⚠  - lib: do not provide an empty Proxy from localStorage getter
   ⚠  - v8: changing total_allocated_bytes to avoid ABI changes
   ⚠  - increasing node embedder number
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/21052182155

[aduh95]

This needs a rebase

[caiolima]

Done. Thanks for the ping.

[caiolima]

The error seems unrelated to this PR. Could anybody trigger the CI again please?