More strict fixes and removal of bind() in most cases #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
nitrog7
commented
Apr 26, 2014
nitrog7
commented
- Adds single quote strict rules
- No more nested functions within loops
fix #139, allow embedded queries in FROM
Using socket.end is hanging the process - socket.destroy with case-handling seem to be making it work. Refer: http://nodejs.org/api/net.html#net_socket_destroy vs http://nodejs.org/api/net.html#net_socket_end_data_encoding
fix error messages, no more RequestError: null
manual merge of #141
add RID::equals()
Make list command output the correct list of dbs on the server (also removed the help / guidance messages so it just outputs a plain list I can pipe into grep easily)
List CLI command output correct data.
add db.registerTransformer()
ensure prefetched records are resolved via ridbags
guarantee migration order
RID query fixes
A solution for issue #279
Added milliseconds to the date conversion.
Missing `readonly` on Property update
Feature/db.class.update
fixed serialization issue (multiple backslash)
I couldn't figure out if there was a reason that a leading / (forward slash) is being escaped. However, because of this, trying to save a value that begins with a forward slash causes a lexical error in the SQL. (OreintDB 2.1 rc3).
Added tests that inserts and reads records with fields starting with a slash.
Escaping / (forward slash) causes SQL errors
adds descriptions to nested errors, should fix #324
Prepare 1.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.