Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2080 +/- ##
==========================================
- Coverage 91.33% 91.32% -0.02%
==========================================
Files 66 66
Lines 16274 16274
==========================================
- Hits 14864 14862 -2
- Misses 1410 1412 +2
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
A crash in a test?
https://github.com/ni/nimi-python/actions/runs/13359250170/job/37306365454 |
bkeryan
left a comment
There was a problem hiding this comment.
Approved with suggestions
|
@marcoskirsch |
What does this Pull Request accomplish?
Adds official Python 3.13 support to nimi-python through testing.
The version of Python used by readthedocs for documentation generation remains unchanged at 3.11. I prefer to be intentional about changes to the generation of documentation.
Update
grpcio,protobufdeps for Python 3.13 compatibilityInitially attempted codegen with Python 3.13 and chose
grpcio,protobufversions for compatibility with the newergrpcio-toolsversion. We decided to continue generating pb2 files with Python 3.12 to avoid breaking compatibility with other NI Python packages. See this discussion. Afterward, I kept thegrpcio,protobufversions in our tox .inis because I knew they were compatible with Python 3.13 and can be used if/when we begin code-generating with Python 3.13.grpcio-tools compatibility for version 1.67.0 (The earliest version with a 3.13 wheel)
Due to generating with the same
grpcio-toolsversion as before, I had to disable theensure_codegen_up_to_datecheck on Python 3.13, though it still runs on the other versions.List issues fixed by this Pull Request below, if any.
What testing has been done?
PR Checks