Skip to content

Active share validation/authoritative mount improvements#57760

Open
icewind1991 wants to merge 17 commits intomasterfrom
share-update-check-single
Open

Active share validation/authoritative mount improvements#57760
icewind1991 wants to merge 17 commits intomasterfrom
share-update-check-single

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Jan 23, 2026 •
edited
Loading

  • For events where we know the share, only check/register mount for that share
  • Above a certain number of users, postpone the checks till fs setup time for the user

@icewind1991 icewind1991 added this to the Nextcloud 34 milestone Jan 23, 2026
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 23, 2026
@icewind1991 icewind1991 requested a review from a team as a code owner January 23, 2026 15:03
@icewind1991 icewind1991 requested review from Altahrim, ArtificialOwl, nfebe and salmart-dev and removed request for a team January 23, 2026 15:03
@artonge artonge mentioned this pull request Jan 23, 2026
Open
@icewind1991 icewind1991 force-pushed the share-update-check-single branch from b1a28af to 054c5c0 Compare January 23, 2026 15:19
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Jan 23, 2026
@nickvergessen
test: Run tests from nextcloud/server#57760 "fix: only validate mount…
095ab2e 
…s for new share"

Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Jan 23, 2026
@nickvergessen
test: Run tests from nextcloud/server#57760 "fix: only validate mount…
46f7a27 
…s for new share"

Signed-off-by: Joas Schilling <coding@schilljs.com>
@icewind1991 icewind1991 force-pushed the share-update-check-single branch from 054c5c0 to 3e548a5 Compare January 23, 2026 15:32
@nickvergessen nickvergessen mentioned this pull request Jan 27, 2026
Closed
@icewind1991 icewind1991 force-pushed the share-update-check-single branch from 3e548a5 to 4851386 Compare February 5, 2026 13:48
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Feb 5, 2026
@nickvergessen
test: Run tests against nextcloud/server#57760 share-update-check-single
4dee540 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen mentioned this pull request Feb 5, 2026
Draft
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Feb 6, 2026
@nickvergessen
test: Run tests against nextcloud/server#57760 share-update-check-single
b303266 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@icewind1991 icewind1991 force-pushed the share-update-check-single branch 2 times, most recently from 000d868 to 716d880 Compare February 9, 2026 15:48
@icewind1991 icewind1991 changed the title fix: only validate mounts for new share Active share validation improvements Feb 12, 2026
@icewind1991 icewind1991 marked this pull request as draft February 12, 2026 14:09
@icewind1991 icewind1991 force-pushed the share-update-check-single branch 2 times, most recently from b35ead2 to 8e50698 Compare February 17, 2026 13:54
@icewind1991 icewind1991 changed the title Active share validation improvements Active share validation/authoritative mount improvements Feb 17, 2026
@icewind1991 icewind1991 force-pushed the share-update-check-single branch 3 times, most recently from f29cc31 to 4b00db9 Compare February 18, 2026 16:00
@icewind1991 icewind1991 force-pushed the share-update-check-single branch 3 times, most recently from 356d8f8 to 4de187a Compare February 25, 2026 15:56
@icewind1991 icewind1991 marked this pull request as ready for review February 25, 2026 19:56
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Feb 27, 2026
@nickvergessen
test: Run tests against nextcloud/server#57760 share-update-check-single
17d763a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member

nickvergessen commented Feb 27, 2026

Retriggered talk tests in nextcloud/spreed#16987
Looks good with the test adjustments

@icewind1991
Copy link
Member Author

icewind1991 commented Mar 4, 2026

Added #58727 which is separate since it needs to be backported further.

@icewind1991 icewind1991 force-pushed the share-update-check-single branch from 0a8ad13 to cd161cc Compare March 5, 2026 12:20
salmart-dev
salmart-dev reviewed Mar 5, 2026
View reviewed changes
lib/private/Files/FileInfo.php

public function getData() {
return $this->data;
public function getData(): ICacheEntry {
Copy link
Contributor

@salmart-dev salmart-dev Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment: I feel like we should have interfaces extending the public ones so that we can actually add methods like this there 🤔 It would double the amount of interfaces we have though 👀 or... we could just do it for the ones where we need to add non-OCP functions

nickvergessen added a commit to nextcloud/spreed that referenced this pull request Mar 6, 2026
@nickvergessen
test: Run tests against nextcloud/server#57760 share-update-check-single
4edcd5e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@icewind1991
fix: only validate mounts for new share
1ea3f92 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: add event for user home mount having being setup
13c07d1 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
chore: move share recipient validation logic to a separate class
f134ce2 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: postpone receiving share validation after processing a certain …
f8ef90b 
…number of users

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
test: add test for delayed share validate
44bfd5e 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: disable share resolve postpone in tests
6d03b29 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: export getData for public FileInfo interface
5b54ab9 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: clear in-memory cached mounts for user when adding/removing mounts
b4b21f3 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
test: add reusable mock implementation for IAppConfig
91bc980 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
test: add reusable mock implementation for IUserConfig
ee0dc72 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
test: add some tests for SharesUpdatedListenerTest
015aecf 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
test: add some tests for ShareRecipientUpdaterTest
64c754c 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: use time-based cutoff for share updating instead of count
eacf216 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: improve performance of handling delete shares
cad3691 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: add output options and '--cached-only' to list mounts command
b7a2c2e 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: update shares on group delete
b5787c2 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
test: add more integration tests for share mount handling
a5df48f 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the share-update-check-single branch from cd161cc to a5df48f Compare March 10, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@salmart-dev salmart-dev salmart-dev left review comments

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@artonge artonge Awaiting requested review from artonge

@provokateurin provokateurin Awaiting requested review from provokateurin

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

6 participants

@icewind1991 @nickvergessen @salmart-dev @artonge @CarlSchwan @provokateurin