Skip to content

refactor(IShare): Add typing for IShare #57575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
CarlSchwan wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

refactor(IShare): Add typing for IShare #57575

CarlSchwan wants to merge 1 commit into from
+170 −237

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Jan 15, 2026 •
edited
Loading

Summary

This might also improve a bit the performance as we are spending 2-3% of CPU time in IShare::setId

TODO

  • ...

Checklist

@CarlSchwan CarlSchwan added this to the Nextcloud 33 milestone Jan 15, 2026
@CarlSchwan CarlSchwan self-assigned this Jan 15, 2026
@CarlSchwan CarlSchwan marked this pull request as ready for review January 15, 2026 17:41
@CarlSchwan CarlSchwan requested a review from a team as a code owner January 15, 2026 17:41
@CarlSchwan CarlSchwan requested review from ArtificialOwl, come-nc, leftybournes and provokateurin and removed request for a team January 15, 2026 17:41
@CarlSchwan CarlSchwan changed the title refactor(IShare): Add typing for node refactor(IShare): Add typing for IShare Jan 15, 2026
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 15, 2026
Merged
@CarlSchwan CarlSchwan force-pushed the carl/typing-share branch 4 times, most recently from 8b6715c to cec0a3b Compare January 16, 2026 13:22
artonge
artonge reviewed Jan 16, 2026
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For v34?

@CarlSchwan CarlSchwan modified the milestones: Nextcloud 33, Nextcloud 34 Jan 16, 2026
@CarlSchwan
Copy link
Member Author

CarlSchwan commented Jan 16, 2026

For v34?

Yeah feels tiny to risky to do that in 33. Not worth the tiny performance improvements

provokateurin
provokateurin reviewed Jan 19, 2026
View reviewed changes
@CarlSchwan
refactor(IShare): Add typing for node
c1575e9 
This might also improve a bit the performance.

Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan CarlSchwan marked this pull request as draft January 20, 2026 09:34
@CarlSchwan
Copy link
Member Author

CarlSchwan commented Jan 20, 2026

Converting to draft until we do a branching as this is NC 34 only material

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge left review comments

@provokateurin provokateurin provokateurin left review comments

@Altahrim Altahrim Altahrim approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Assignees

@CarlSchwan CarlSchwan

Labels

3. to review Waiting for reviews performance 🚀 technical debt

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

5 participants

@CarlSchwan @Altahrim @artonge @provokateurin