style(file-list-actions): use m3 buttons instead of linear layout#16601
Draft
alperozturk96 wants to merge 2 commits intomasterfrom
Draft
style(file-list-actions): use m3 buttons instead of linear layout#16601alperozturk96 wants to merge 2 commits intomasterfrom
alperozturk96 wants to merge 2 commits intomasterfrom
Conversation
alperozturk96
requested review from
AndyScherzinger
and removed request for
AndyScherzinger and
tobiasKaminsky
Collaborator
Author
|
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
change-file-list-action-style
branch
from
566d35b to
9b37a93
Compare
alperozturk96
commented
Feb 27, 2026
| for (creator in directEditing.creators.values) { | ||
| val creatorViewBinding = | ||
| FileListActionsBottomSheetCreatorBinding.inflate(layoutInflater) | ||
| val creatorButton = MaterialButton( |
Collaborator
Author
There was a problem hiding this comment.
How can I test all possible creator buttons? @tobiasKaminsky
Member
There was a problem hiding this comment.
I'd say it the fab on root level of production can be considered "good enough"
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16601.apk |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Uses M3 Icon button instead of
LinearLayoutChanges tap animation
Before
before.mp4
After
after.mp4