Skip to content

Comments

Screenshot tests were failing, JUnit downgrade needed#16578

Open
tobiasKaminsky wants to merge 7 commits intomasterfrom
screenshotTestsDowngradeJunit
Open

Screenshot tests were failing, JUnit downgrade needed#16578
tobiasKaminsky wants to merge 7 commits intomasterfrom
screenshotTestsDowngradeJunit

Conversation

@tobiasKaminsky
Copy link
Member

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🏁 Checklist

  • Tests written, or not not needed

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
Copy link
Member Author

13:19: There was 46 failure(s).

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link

Codacy

SpotBugs

CategoryBaseNew
Bad practice4242
Correctness7575
Dodgy code253256
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4444
Security1818
Total476479

SpotBugs increased!

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16578.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant