Enhance PyNUTClient with SSL (NUT STARTTLS) support and test it#3352
Merged
jimklimov merged 20 commits intonetworkupstools:masterfrom Mar 20, 2026
Merged
Enhance PyNUTClient with SSL (NUT STARTTLS) support and test it#3352jimklimov merged 20 commits intonetworkupstools:masterfrom
jimklimov merged 20 commits intonetworkupstools:masterfrom
Conversation
…p(), and reasons to abort net_starttls() Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ing sockets [networkupstools#3331] Apply same retry detection and loop logic as for handshake; standardize on `SSL_IO_MAX_RETRIES` constant name for these operations. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…able SSL_ERROR_WANT_{WRITE,READ}, log less loudly [networkupstools#3331]
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added
enhancement
CI
|
❌ Build nut 2.8.4.4333-master failed (commit 543d2bde30 by @jimklimov) |
…ols#1711, networkupstools#3329, networkupstools#1600] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… key/cert file locations) [networkupstools#1711, networkupstools#3329, networkupstools#1600] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…upstools#1711, networkupstools#1600] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…IT tests [networkupstools#1711, networkupstools#3329, networkupstools#1600] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added
the
AI
Member
Author
|
Seems python-3.13+ includes much stricter rules about certificate validation, and we generate something not up to its spec (not all extensions it wants) at least for the CA certificate. |
…ERIFY to be numbers [networkupstools#1711, networkupstools#1600] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…d python OpenSSL handling) [networkupstools#1600, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…CERTVERIFY to accept numbers [networkupstools#1711, networkupstools#1600] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… required nowadays by many crypto implementations [networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…rkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…pstools#1600, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
❌ Build nut 2.8.4.4347-master failed (commit d8cf826813 by @jimklimov) |
…cates, exit() upon errors; invert WITHOUT_SSL_TESTS=>WITH_SSL_TESTS with more options [networkupstools#1711] Support now `make check-NIT WITH_SSL_TESTS=required-conditional` to fail fast if crypto material setup failed (ignored if built without SSL). Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… self-signed CA cert [networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…der Python libs [networkupstools#1711, networkupstools#1600] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…TS=required (to abort if NUT was built without SSL support) [networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…UT was built with SSL support) but needed third-party tooling was not found for SSL setup [networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…edora 43 setup [networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses issues:
AI DISCLAIMER: Prepared with contributions from IntelliJ Junie