Skip to content

[fix] Correctly propagate pointer-events: auto to children when set to box-none #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hassankhan wants to merge 1 commit into from
+27 −3
Closed

[fix] Correctly propagate pointer-events: auto to children when set to box-none #2789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-native-web/src/exports/AppRegistry/__tests__/__snapshots__/index-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ exports[`AppRegistry runApplication styles roots in different documents 1`] = `
".r-bottom-1p0dtai {bottom: 0px;}",
".r-left-1d2f490 {left: 0px;}",
".r-pointerEvents-105ug2t {pointer-events: auto !important;}",
".r-pointerEvents-12vffkv>* {pointer-events: auto;}",
".r-pointerEvents-12vffkv * {pointer-events: auto;}",
".r-pointerEvents-12vffkv {pointer-events: none !important;}",
".r-pointerEvents-633pao {pointer-events: none !important;}",
".r-pointerEvents-ah5dr5>* {pointer-events: none;}",
Expand All @@ -43,7 +43,7 @@ exports[`AppRegistry runApplication styles roots in different documents 2`] = `
".r-bottom-1p0dtai {bottom: 0px;}",
".r-left-1d2f490 {left: 0px;}",
".r-pointerEvents-105ug2t {pointer-events: auto !important;}",
".r-pointerEvents-12vffkv>* {pointer-events: auto;}",
".r-pointerEvents-12vffkv * {pointer-events: auto;}",
".r-pointerEvents-12vffkv {pointer-events: none !important;}",
".r-pointerEvents-633pao {pointer-events: none !important;}",
".r-pointerEvents-ah5dr5>* {pointer-events: none;}",
Expand Down
24 changes: 24 additions & 0 deletions packages/react-native-web/src/exports/StyleSheet/__tests__/compiler-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,30 @@ describe('StyleSheet/compile', () => {
]
`);
});

Copy link
Contributor Author

@hassankhan hassankhan Jul 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to remove the test if the maintainer(s) think the snapshot test above suffices

test('when parent is pointer-events=box-none, pointer-events=auto applied to children', () => {
const result = atomic({
pointerEvents: 'box-none'
});

expect(result).toMatchInlineSnapshot(`
[
{
"$$css": true,
"pointerEvents": "r-pointerEvents-12vffkv",
},
[
[
[
".r-pointerEvents-12vffkv * {pointer-events:auto;}",
".r-pointerEvents-12vffkv{pointer-events:none!important;}",
],
3,
],
],
]
`);
});
});

describe('classic', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-web/src/exports/StyleSheet/compiler/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ function createAtomicRules(identifier: string, property, value): Rules {
finalValue = 'none!important';
if (value === 'box-none') {
const block = createDeclarationBlock({ pointerEvents: 'auto' });
rules.push(`${selector}>*${block}`);
rules.push(`${selector} * ${block}`);
}
}
const block = createDeclarationBlock({ pointerEvents: finalValue });
Expand Down
Loading