fix: Re-enable Playwright tests in CI #137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mashalifshin
force-pushed
the
fix-playwright-tests-again-more-better
branch
from
6b5e09c to
6672c7f
Compare
mashalifshin
force-pushed
the
fix-playwright-tests-again-more-better
branch
from
6672c7f to
a6ddd73
Compare
Contributor
Author
|
Oh dear, seeing failures again. The staging image cache is back to this behavior: 
You can repro by just running any of the examples. I wonder if we should try to request some prioritization for this now, before we want to get active on this repo again? This is the ticket with SRE, SREIN-200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
We had to disable the Playwright tests a few months ago because we were no longer consistently getting ads, alt texts, and images served.
Proposed Changes
It seems like the issues with mock ads/staging ads have been resolved since then. Just enable the tests again. 🤞
Verification Steps
Check the github actions on this PR to see that the tests seem to be running fine again