Conversation
|
Things to be aware of:
|
|
@PeterMitrano we (hopefully) fixed the links in this independent PR, so your patches do not apply anymore. Could you please clean up this PR? |
|
Seems the python docs are still not being generated. |
davetcoleman
left a comment
davetcoleman
left a comment
There was a problem hiding this comment.
Can you add a photo to the top of the tutorial, to provider readers more visual appeal?
| # but this method of instantiation is only intended for illustration. | ||
|
|
||
| urdf_path = "/opt/ros/noetic/share/moveit_resources_panda_description/urdf/panda.urdf" | ||
| srdf_path = "/opt/ros/noetic/share/moveit_resources_panda_moveit_config/config/panda.srdf" |
There was a problem hiding this comment.
This is a brittle way to load resoruces in ROS. Use the resource_load (I think that's the name) to resolve package names, without hard coding paths to someone's specific computer
There was a problem hiding this comment.
do you mean this? http://wiki.ros.org/resource_retriever
or just the rospkg python API? I think rospkg would work fine, assuming the person has the moveit_resources_panda_* packages available
|
note to self this PR is currently pending on resolving the issues mentioned in moveit/moveit#2606 |
| # on the end-effector of the panda_arm group of the Panda robot. Note the | ||
| # use of convenience functions for filling up the constraints | ||
|
|
||
| end_effector_name = joint_model_group.getLinkModelNames()[-1] |
There was a problem hiding this comment.
Is there a way to explicitly get the end effector link name from the robot model, instead of implicitly finding it as the last entry in the list of all links?
There was a problem hiding this comment.
that would be nice, alas there aren't bindings for that yet.
JStech
left a comment
JStech
left a comment
There was a problem hiding this comment.
I was able to build and run this, with some extra imports. It looks good and is informative.
Some of the tutorial comment blocks have very uneven line lengths--I'd recommend adjusting them to be more regular (there's probably a tool that will do this for you).
Co-authored-by: Joseph Schornak <[email protected]>
Co-authored-by: John Stechschulte <[email protected]>
Co-authored-by: John Stechschulte <[email protected]>
PeterMitrano
force-pushed
the
moveit_core_python_tutorials
branch
from
6f7d124 to
7bf2f54
Compare
|
Did a rebase, sorry if that messed up the review. This PR is still blocked by issues mentioned in moveit/moveit#2606 |
Co-authored-by: John Stechschulte <[email protected]>
Co-authored-by: John Stechschulte <[email protected]>
6 participants
Description
Add tutorials for the new python interface to moveit_core. This is adapted from the C++ planning scene tutorial
Checklist