PYTHON-5695 Clarify NoWritesPerformed error label behavior when multiple retries occur#2707
Draft
blink1073 wants to merge 3 commits intomongodb:backpressurefrom
Draft
PYTHON-5695 Clarify NoWritesPerformed error label behavior when multiple retries occur#2707blink1073 wants to merge 3 commits intomongodb:backpressurefrom
blink1073 wants to merge 3 commits intomongodb:backpressurefrom
Conversation
blink1073
commented
Feb 17, 2026
| # code `91` (NotWritablePrimary) and the `NoWritesPerformed`, `RetryableError` and `SystemOverloadedError` labels. | ||
| command_args_inner = { | ||
| "configureFailPoint": "failCommand", | ||
| "mode": "alwaysOn", |
Member
Author
There was a problem hiding this comment.
@NoahStapp I had to change this from the spec because otherwise the error is never triggered (it is retried). I think this was a bug in the original spec, since I'm the first one implementing it. Should I make a PR to update the specification?
Contributor
There was a problem hiding this comment.
Can you describe the change you had to make?
Member
Author
There was a problem hiding this comment.
I think it was a copy-paste error. I had to change mode: {times: 1} to mode: alwaysOn for the second failCommand to ensure it failed on backpressure retries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5695
Changes in this PR
Add prose tests to verify the handling of the
NoWritesPerformederror label behavior when multiple retries occur.Test Plan
Standard tests.
Checklist
Checklist for Author
Checklist for Reviewer