Skip to content

Conversation

@sanych-sun
Copy link
Member

@sanych-sun sanych-sun commented May 16, 2025

PR contains fixes for:

  • run MongoDB.Driver.Encryption.Tests to run on net472 target (filter by test name to MongoDB.Driver.Encryption.Tests to see new tests run on net472 variants)
  • remove installation of netcore 2.1 as we dropped support of netstandard2.0
  • remove some leftovers in cake for Legacy Driver
  • fix for Warning MSB3243 : No way to resolve conflict between "Microsoft.CSharp, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" and "Microsoft.CSharp".

@sanych-sun sanych-sun requested a review from BorisDog May 16, 2025 17:02
@sanych-sun sanych-sun requested a review from a team as a code owner May 16, 2025 17:02
@sanych-sun sanych-sun added the chore Non–user-facing code changes (tests, build scripts, etc.). label May 16, 2025
Copy link
Contributor

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + comment + check tests.

items: GetFiles("./**/*.Tests.csproj").Where(name => !name.ToString().Contains("Atlas")),
action: (BuildConfig buildConfig, Path testProject) =>
{
if (Environment.GetEnvironmentVariable("MONGODB_API_VERSION") != null &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" PrivateAssets="All" Version="1.0.0" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combine with other PackageReference.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved into Test.Build.props file

@sanych-sun sanych-sun merged commit 1713173 into mongodb:main May 16, 2025
273 of 299 checks passed
@sanych-sun sanych-sun deleted the csharp5591 branch May 16, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Non–user-facing code changes (tests, build scripts, etc.).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants