Skip to content

fix(specs-go): remove omitempty from Model.Config json tag#177

Open
rishi-jat wants to merge 1 commit intomodelpack:mainfrom
rishi-jat:fix/remove-omitempty-from-model-config
Open

fix(specs-go): remove omitempty from Model.Config json tag#177
rishi-jat wants to merge 1 commit intomodelpack:mainfrom
rishi-jat:fix/remove-omitempty-from-model-config

Conversation

@rishi-jat
Copy link

The JSON schema requires the config field to be present.
The Go Model struct allowed it to be omitted due to the omitempty tag.

This change removes omitempty to align the Go struct with the schema requirement.

Signed-off-by: Rishi Jat <rishijat098@gmail.com>
Copilot AI review requested due to automatic review settings February 28, 2026 13:44
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an inconsistency between the Go Model struct and its corresponding JSON schema. By removing the omitempty tag from the Config field, the Go struct now correctly enforces that the config field must always be present in the JSON output, ensuring data integrity and schema compliance.

Highlights

  • JSON Tag Alignment: Removed the omitempty tag from the Config field in the Model struct to ensure it is always present when marshaling/unmarshaling JSON, aligning with the JSON schema requirement.
Changelog
  • specs-go/v1/config.go
    • Removed omitempty from the json:"config,omitempty" tag for the Config field in the Model struct.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the omitempty JSON tag from the Config field within the Model struct. This change correctly aligns the Go struct with the JSON schema, which mandates the presence of the config field. The modification is accurate and addresses the discrepancy as described.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns the Go Model struct JSON encoding with the JSON Schema requirement that the config field must always be present in serialized model configs.

Changes:

  • Removed omitempty from Model.Config JSON tag so config is always emitted during JSON marshaling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rishi-jat
Copy link
Author

/cc @chlins
/cc @aftersnow
/cc @bergwolf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants