fix(specs-go): remove omitempty from Model.Config json tag#177
fix(specs-go): remove omitempty from Model.Config json tag#177rishi-jat wants to merge 1 commit intomodelpack:mainfrom
Conversation
Signed-off-by: Rishi Jat <rishijat098@gmail.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an inconsistency between the Go Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the omitempty JSON tag from the Config field within the Model struct. This change correctly aligns the Go struct with the JSON schema, which mandates the presence of the config field. The modification is accurate and addresses the discrepancy as described.
There was a problem hiding this comment.
Pull request overview
Aligns the Go Model struct JSON encoding with the JSON Schema requirement that the config field must always be present in serialized model configs.
Changes:
- Removed
omitemptyfromModel.ConfigJSON tag soconfigis always emitted during JSON marshaling.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/cc @chlins |
The JSON schema requires the config field to be present.
The Go Model struct allowed it to be omitted due to the omitempty tag.
This change removes omitempty to align the Go struct with the schema requirement.