fix(filesystem): gracefully handle unavailable directories#3187
Open
eran3d wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(filesystem): gracefully handle unavailable directories#3187eran3d wants to merge 1 commit intomodelcontextprotocol:mainfrom
eran3d wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Instead of crashing when a configured directory is unavailable (e.g., unmounted external drive, disconnected network share), the server now: - Skips unavailable directories with a warning log - Continues operating with the remaining available directories - Only exits if ALL specified directories are unavailable This allows users with external drives or network shares to configure all their directories without the server failing when some are temporarily unavailable. Fixes modelcontextprotocol#2815
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instead of crashing when a configured directory is unavailable (e.g., unmounted external drive, disconnected network share), the server now skips unavailable directories with a warning and continues operating with the remaining available directories.
Problem
Currently, if any directory in
allowed_directoriesis unavailable at startup, the entire server crashes withprocess.exit(1). This makes ALL filesystem access unavailable, even for paths that are accessible.This is particularly problematic for:
Solution
The server now:
Example log output
Testing
Tested locally with a mix of available and unavailable directories. The server now starts successfully and operates on the available directories while logging warnings about the unavailable ones.
Fixes #2815