mcp: add Capabilities fields to ServerOptions and ClientOptions #713
+1,071
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findleyr
changed the title
findleyr
force-pushed
the
capabilities-refactor
branch
5 times, most recently
from
a04ada4 to
cb0fcb7
Compare
findleyr
commented
Dec 11, 2025
Contributor
Author
findleyr
left a comment
findleyr
left a comment
There was a problem hiding this comment.
Markus: could you please review carefully:
- The new inference logic (both
capabilitiesandshould...methods) - The API and API documentation.
markus-kusano
previously approved these changes
Dec 11, 2025
findleyr
force-pushed
the
capabilities-refactor
branch
from
f0c79e7 to
bd6521a
Compare
jba
previously approved these changes
Dec 11, 2025
findleyr
force-pushed
the
capabilities-refactor
branch
2 times, most recently
from
0829c36 to
4430d6f
Compare
This allows users to configure default capabilities, disable defaults, or suppress listChanged notifications by setting ListChanged: false. Key changes: - Add ServerOptions.Capabilities and ClientOptions.Capabilities fields. - Merge user-provided capabilities with dynamically-added ones (tools, prompts, resources, sampling, elicitation). - Check ListChanged before sending list-changed notifications. - Deprecate HasPrompts, HasResources, HasTools on ServerOptions. - Remove unreleased ElicitationModes field from ClientOptions. - Add clone methods to capability structs using shallowClone helper. - Add synctest-based tests for notification behavior (go1.25). - Add TestClientCapabilitiesOverWire and TestServerCapabilitiesOverWire - Document the new Capabilities API in docs/ Updates modelcontextprotocol#706
findleyr
force-pushed
the
capabilities-refactor
branch
from
4430d6f to
d257480
Compare
markus-kusano
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to configure default capabilities, disable defaults,
or suppress listChanged notifications by setting ListChanged: false.
Key changes:
prompts, resources, sampling, elicitation).
Fixes #706