Adding conditional formatting for big number charts.#33
Adding conditional formatting for big number charts.#33leeorengel wants to merge 1 commit intomode:masterfrom
Conversation
|
Hi @leeorengel , thanks for submitting this PR. |
leqilong
left a comment
There was a problem hiding this comment.
Hi @leeorengel ,
var bigNumber = content[0][columnName] this line would always return the first row's values from query results. It won't return the correct the big number if the big number chart is configured to show sum/average/max/last row, etc.
Modeled after the conditional formatting for tables, this adds support for coloring big number charts. Thresholds follow the same rules as the other conditional formatting methods.
Here's a screenshot of what it looks like on a mode report (using the code in this PR as in-lined JS in the report)