example update #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi Jocs, Thanks for the pull request! I left a few comments in the code. A Chinese translation sounds great - do you want to submit a separate pull request for that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, mknichel, I really like this article, and have used some examples in my javascript error track project, thank you for your great work on javascript error.
but when i rewrite the Promise.prototype.then method, I found that my '.catch' can not catch error, so I think we should rethrow the error in catch block of 'protectEntryPoint' function.
One more thing, when we use the 'protectEntryPoint' function, we should check the arguments type, and make sure its 'function' type.
Thank you again for you article, I have translated a Chinese version, if you prefer a Chinese version, I'll PULL another request.