Fix notification marking for merged PRs with bot comments #8281
+24
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notifications for user-created PRs were not being marked as done after the user merged them, particularly when bots had commented after the user's last action.
Changes
EventType.Mergednow counts when determining if the user was the last to interact with a PR_isBot()method that identifies bots viaAccountType.Bot,[bot]suffix, or configurable username listAUTOMATED_USERSconstant (includesvs-code-engineering) for maintainabilityImplementation
Bot filtering applied to all timeline event types (commits, comments, reviews, merges):
Now when
markPullRequests()walks the timeline backwards to find meaningful events, bot actions are skipped. If the user's last meaningful action (including merges) is more recent than any non-bot user's action, the notification is marked as done.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
update.code.visualstudio.com/opt/hostedtoolcache/node/20.19.6/x64/bin/node node ./out/src/test/runTests.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.