-
Notifications
You must be signed in to change notification settings - Fork 704
Link commit SHAs in inline file comments #8278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+89
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: alexr00 <[email protected]>
Co-authored-by: alexr00 <[email protected]>
Co-authored-by: alexr00 <[email protected]>
Co-authored-by: alexr00 <[email protected]>
Co-authored-by: alexr00 <[email protected]>
Copilot
AI
changed the title
[WIP] Fix commit SHAs highlighting in PR comments
Link commit SHAs in inline file comments
Dec 10, 2025
alexr00
requested changes
Dec 15, 2025
Member
alexr00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot test failure in CI:
1) commit SHA replacement
should not match SHAs in code blocks:
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
1 !== 2
+ expected - actual
-1
+2
at Context.<anonymous> (src/test/github/prComment.test.ts:35:10)
at processImmediate (node:internal/timers:485:21)
Co-authored-by: alexr00 <[email protected]>
Contributor
Author
alexr00
approved these changes
Dec 15, 2025
dmitrivMS
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue where commit SHAs mentioned in PR comments are not highlighted and hyperlinked when viewed in the file view (inline comments).
Changes Completed
Implementation Details
Core Changes (
src/github/prComment.ts)COMMIT_SHA_EXPRESSIONregex constant to match 7 or 40-character commit SHAsreplaceCommitShas()method that:[shortSha](https://host/owner/repo/commit/sha)replaceBody()transformation pipelineTests (
src/test/github/prComment.test.ts)COMMIT_SHA_EXPRESSIONconstant for consistencySecurity
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.