Skip to content

Auto import memory optimizations#2991

Merged
andrewbranch merged 14 commits intomicrosoft:mainfrom
andrewbranch:auto-import-memory-optimizations
Mar 5, 2026
Merged

Auto import memory optimizations#2991
andrewbranch merged 14 commits intomicrosoft:mainfrom
andrewbranch:auto-import-memory-optimizations

Conversation

@andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Mar 5, 2026

Should help #2780

Results

Measured by opening one file in each workspace package and triggering auto-imports.

repo-pnpm - 10 packages

  /gc/heap/live:bytes
nightly 1,245,135,800
pr 753,368,456

vscode - 1 package

  /gc/heap/live:bytes
nightly 1,590,839,104
pr 1,089,793,528

DefinitelyTyped-tools - 14 packages

  /gc/heap/live:bytes
nightly 476,638,976
pr 368,886,320

@andrewbranch andrewbranch marked this pull request as ready for review March 5, 2026 18:35
Copilot AI review requested due to automatic review settings March 5, 2026 18:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@andrewbranch andrewbranch requested a review from Copilot March 5, 2026 18:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally not for this PR, but for the language server, I wonder if we should just say "GetSourceFile must always returns a bound file" given we largely assume that to be the case.

@andrewbranch andrewbranch added this pull request to the merge queue Mar 5, 2026
Merged via the queue into microsoft:main with commit 03006a8 Mar 5, 2026
21 checks passed
@andrewbranch andrewbranch deleted the auto-import-memory-optimizations branch March 5, 2026 20:46
@goloveychuk
Copy link

image
(It's found by ai. With my idea/assumption though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants