Conversation
- Use the master branch of microsoft/snmalloc - Fix Documentation
- update README.md - add ci - fix windows and osx build
Minor typos/rewording.
…ws to add /DNDEBUG
improving the performance in Windows
maintenance work
Bumps [snmalloc-sys/snmalloc](https://github.com/microsoft/snmalloc) from `7e22d30` to `1d72024`. - [Release notes](https://github.com/microsoft/snmalloc/releases) - [Commits](microsoft/snmalloc@7e22d30...1d72024) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…ules/snmalloc-sys/snmalloc-1d72024 Bump snmalloc-sys/snmalloc from `7e22d30` to `1d72024`
`snmalloc` now supports alignment of all allocations with microsoft#124 This comment is no longer required.
Improve documents after upstream update
Bumps [snmalloc-sys/snmalloc](https://github.com/microsoft/snmalloc) from `4367a0c` to `3775a62`. - [Release notes](https://github.com/microsoft/snmalloc/releases) - [Commits](microsoft/snmalloc@4367a0c...3775a62) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…ules/snmalloc-sys/snmalloc-3775a62 Bump snmalloc-sys/snmalloc from `4367a0c` to `3775a62`
Bumps [snmalloc-sys/snmalloc](https://github.com/microsoft/snmalloc) from `3775a62` to `ef77bcc`. - [Release notes](https://github.com/microsoft/snmalloc/releases) - [Commits](microsoft/snmalloc@3775a62...ef77bcc) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Update build.rs improve compatibilty and build errors on build_cc/cmake for windows * Update build.rs improve clang64 MSYSTEM linking pass tests * Update lib.rs, thread/process share safety null catches * Update build.rs ninja not necessary * Update build.rs ubuntu fix * Update build.rs unify builds and reconfigure freebsd In testing I noticed an almost doubling of test time between build_cc and cmake, they are now unified to make sure there is reduced chance of difference between builds. also enabled ability to read build environment of allocator * Update build.rs correct ubuntu linking to stdc++ for thread local safety * Update build.rs remove gcc link for tls * Update build.rs freebsd link c++ * Update build.rs LTO/IPO working on all builds, unix/linux * Update build.rs don't need static lib * Update build.rs correct lib location differences on windows * Update build.rs revert unix * Update build.rs unix family includes linux
* Update snmalloc to 0.7.1 This tracks the upstream changes in snmalloc 0.7.1. * Address warning from CI.
Collaborator
|
Thanks for doing this. I will take a look of the porting process! |
mjp41
force-pushed
the
snmalloc-rs-integration
branch
3 times, most recently
from
855b2f2 to
83a602a
Compare
Collaborator
|
On windows, zero-sized array potentially requires specialization. |
Collaborator
|
use |
Member
Author
|
@SchrodingerZhu, do you have any ideas why it keeps building Release static lib when it is a debug build. I don't know really know how to debug this part of the build system. |
Collaborator
|
cmake-rs have some auto detection logic to inject cmake build profile |
mjp41
force-pushed
the
snmalloc-rs-integration
branch
3 times, most recently
from
ca71996 to
2a32bdf
Compare
mjp41
force-pushed
the
snmalloc-rs-integration
branch
from
2a32bdf to
84a0548
Compare
Member
Author
|
@SchrodingerZhu I think this fixes the issues, the refactor of Array, I'll put in another PR as it is not essential to land that for the merge. I just want to double check you are happy with this approach. I believe we will have all the original history, and even be able to apply patches from snmalloc-rs to here. |
Collaborator
|
I am happy with the upstreaming. This also reduces the budern of updating the rust wrapper separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls in the entirety of snmalloc-rs and its history, and places it under snmalloc. This will allow for less breakages of the snmalloc-rs packages, and ensure we update them with all future releases.
See for discussion
#742
This PR is based on
#744
but keeps the history intact.