override add malloc_conceal api proposal#434
override add malloc_conceal api proposal#434devnexen wants to merge 2 commits intomicrosoft:mainfrom
Conversation
368e510 to
2d4b0ce
Compare
a797b2a to
e0937f6
Compare
e0937f6 to
51d6377
Compare
|
Hi, I've thought about adding this API. I think the correct way of doing it is:
They can share the pagemap with other allocators and they should be returned to the pools. Libsodium's secure allocator also supports rounding up allocations to page size, allocating them at the end of the page and putting guard pages on either side. Once the PAL can provide no-core pages, this should also be possible through the large-object paths in the allocator. The allocator rounds up to the page size so that you can mprotect the memory read-only or no-access later. |
|
This is a really interesting idea. I am not sure what the granularity of NODUMP should be. If this is at a Page granularity, then we probably need to allocate whole slabs with NODUMP set. This is doable, but would involve adding a completely different set of sizeclasses for concealed allocations. Adding NODUMP to the PAL is something I have been meaning to do, to address #371. |
you re perfectly right it has to, I was just assessing if the overall idea would hit home before going deeper. |
No description provided.